Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking Issue for Multi Value WASM #578

Closed
CryZe opened this issue Jul 14, 2021 · 3 comments · Fixed by #924
Closed

Tracking Issue for Multi Value WASM #578

CryZe opened this issue Jul 14, 2021 · 3 comments · Fixed by #924
Labels
enhancement A new feature or general improvement to LiveSplit One. needs further discussion / research There's further design decisions that need to be made in order to continue. performance Performance is suboptimal and should be improved.

Comments

@CryZe
Copy link
Collaborator

CryZe commented Jul 14, 2021

Multi-value (+multivalue) is available in all browsers, but Rust seems to have trouble dealing with the ABI change. std is precompiled without multi value, so std is incompatible with your own crates that are compiled with the feature. We may need to build std ourselves with the nightly compiler.
@CryZe CryZe added blocked There's some reason that prevents this work from progressing. enhancement A new feature or general improvement to LiveSplit One. needs further discussion / research There's further design decisions that need to be made in order to continue. performance Performance is suboptimal and should be improved. labels Jul 14, 2021
@CryZe
Copy link
Collaborator Author

CryZe commented Jul 24, 2021

There's two problems with -Z build-std. First of all, it seems to not be able to build std if we activate multivalue, but even if it did, -Z build-std finds the preinstalled std and then complains that it found two versions of std. So yeah this isn't ready at all, I probably need to ping Alex Crichton what the status of / plan for multivalue is.

@CryZe
Copy link
Collaborator Author

CryZe commented Jun 8, 2024 •
edited
Loading

This is actually blocked by something else nowadays. -Z build-std works just fine. However wasm-bindgen isn't compatible with the multivalue ABI:

rustwasm/wasm-bindgen#3552

@CryZe CryZe linked a pull request Jun 8, 2024 that will close this issue
Enable the WebAssembly Multivalue feature #924
Merged
@CryZe
Copy link
Collaborator Author

CryZe commented Jun 8, 2024

I just tried everything again, and it works perfectly fine with at the spec compliant C ABI.

@CryZe CryZe removed the blocked There's some reason that prevents this work from progressing. label Jun 8, 2024
@CryZe CryZe closed this as completed in #924 Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement A new feature or general improvement to LiveSplit One. needs further discussion / research There's further design decisions that need to be made in order to continue. performance Performance is suboptimal and should be improved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable the WebAssembly Multivalue feature CryZe/LiveSplitOne
1 participant
@CryZe