Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HotkeySystem set_config conflict merges badly #815

Open
AlexKnauth opened this issue Jun 10, 2024 · 0 comments
Open

HotkeySystem set_config conflict merges badly #815

AlexKnauth opened this issue Jun 10, 2024 · 0 comments

Comments

@AlexKnauth
Copy link
Contributor

If a HotkeySystem starts out with the default bindings, and then set_config is used to replace those with new bindings, it behaves badly when one of those new bindings conflicts with one of the old bindings.

Old bindings:

Split	Numpad 1
Reset	Numpad 3
Undo	Numpad 8
Skip	Numpad 2
Pause	Numpad 5

PrevCmp	Numpad 4
NextCmp	Numpad 6

New bindings:

Split	Numpad 0
Reset	Numpad 7
Undo	Numpad 4
Skip	Numpad 1
Pause	Pause Break

When it goes to set Undo to Numpad 4, it still sets that in the config, but then signals a failure that leaves the old bindings from Skip onward in place to result in

Badly-merged bindings:

Split	Numpad 0
Reset	Numpad 7
Undo	Numpad 4
Skip	Numpad 2
Pause	Numpad 5

PrevCmp	Numpad 4
NextCmp	Numpad 6

With a conflict between Undo and PrevCmp staying in the config because it didn't go on to set PrevCmp to None.

My desired behavior would be to un-register the conflicting PrevCmp binding before it registers the new Undo binding as Numpad 4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant