Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update module dependencies in code with side effects #37

Closed
rksm opened this issue Nov 7, 2016 · 2 comments
Closed

update module dependencies in code with side effects #37

rksm opened this issue Nov 7, 2016 · 2 comments

Comments

@rksm
Copy link
Member

rksm commented Nov 7, 2016

export var i = 0;
function inc() { i = i+1 }

Running inc should
a) update the exported value for i (what you get when running System.import(...)) and
b) update all dependent modules that import i

This is currently not working b/c we trigger re-exports using a evaluationDone() call at the end of module executions (compiled in as part of rewriting) and evals via lively.vm.

@rksm
Copy link
Member Author

rksm commented Nov 7, 2016

fixed by d1c5702

@rksm rksm closed this as completed Nov 7, 2016
@rksm
Copy link
Member Author

rksm commented Nov 7, 2016

Note that there is an issue with var modifications that aren't assignments such as i++ or i+=1. Since we don't use getters/setters in the recorder anymore, those changes will not trigger an export notification b/c they aren't jet wrapped by our declaration wrapper. This issue is tracked here: LivelyKernel/lively.ast#8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant