You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The tests report: Warning: Closing file descriptor ## on garbage collection
And as consequence: [DEP0137] DeprecationWarning: Closing a FileHandle object on garbage collection is deprecated. Please close FileHandle objects explicitly using FileHandle.prototype.close(). In the future, an error will be thrown if a file descriptor is closed during garbage collection.
The test is somewhat flaky: removing obviously unrelated chunks of the test file makes the issue appear only sometimes, or to not appear at all.
The reason is likely to be READ method and the fd.readableWebStream() in particular. Rewriting it to Node.js Readable fixes the issue. However, I would prefer to keep it using ReadableStream. This looks like either a bug on Node.js side, or just lack of control by design.
It seems that the attempt to close the handle might come after GC.
On a side note, we lack control over the constructor parameters in the helper functions: both stream.Readable.toWeb() and ReadableStream.from() don't allow to set { type: 'bytes' } which is mandatory here. The AbortSignal isn't supported either.
This issue has to be figured out and solved before any rewriting requests with integrity or Range header from chunks to streams.
The text was updated successfully, but these errors were encountered:
The tests report:
Warning: Closing file descriptor ## on garbage collection
And as consequence:
[DEP0137] DeprecationWarning: Closing a FileHandle object on garbage collection is deprecated. Please close FileHandle objects explicitly using FileHandle.prototype.close(). In the future, an error will be thrown if a file descriptor is closed during garbage collection.
The test is somewhat flaky: removing obviously unrelated chunks of the test file makes the issue appear only sometimes, or to not appear at all.
The reason is likely to be
READ
method and thefd.readableWebStream()
in particular. Rewriting it to Node.jsReadable
fixes the issue. However, I would prefer to keep it usingReadableStream
. This looks like either a bug on Node.js side, or just lack of control by design.It seems that the attempt to close the handle might come after GC.
On a side note, we lack control over the constructor parameters in the helper functions: both
stream.Readable.toWeb()
andReadableStream.from()
don't allow to set{ type: 'bytes' }
which is mandatory here. TheAbortSignal
isn't supported either.This issue has to be figured out and solved before any rewriting requests with
integrity
orRange
header from chunks to streams.The text was updated successfully, but these errors were encountered: