Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate ACL for employers only need to approve one time and our contract can change the destination of the flow / update "employer approval" process #13

Open
yukiwaki opened this issue Nov 9, 2022 · 1 comment
Assignees
Labels
high High Priority Issue

Comments

@yukiwaki
Copy link

yukiwaki commented Nov 9, 2022

ACL : Recommended by Fran
"Update" access is needed
https://docs.superfluid.finance/superfluid/developers/constant-flow-agreement-cfa/cfa-access-control-list-acl/acl-features

By using that, employers only need to approve once, and after that our contract can change the destination of the stream (I think this will improve UX a lot better)

This is the implementation for ACL
https://www.notion.so/loanyee532215/ACL-features-4f289af7643d4335b4e84ae49873f197

[Current implementation]

  1. Borrower creates a loan
  2. Loan contract address is generated
  3. Borrower needs to send it to employer
  4. Employer needs to change the destination

[Better implementation with ACL]

  1. Employer approve ACL one time only
  2. Borrower creates a loan → Destination will be automatically changed to the loan contract
@yukiwaki
Copy link
Author

yukiwaki commented Nov 9, 2022

@yukiwaki yukiwaki assigned sajjad1798 and unassigned ericy-eth Nov 21, 2022
@yukiwaki yukiwaki changed the title Integrate ACL so employers only need to approve one time and our contract can change the destination of the flow Integrate ACL for employers only need to approve one time and our contract can change the destination of the flow / update "employer approval" process Nov 23, 2022
@0xefrain 0xefrain removed their assignment Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high High Priority Issue
Projects
None yet
Development

No branches or pull requests

4 participants