Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop client should not force user to setup a local core #290

Open
CheatCod opened this issue Jul 6, 2023 · 2 comments · May be fixed by #324
Open

Desktop client should not force user to setup a local core #290

CheatCod opened this issue Jul 6, 2023 · 2 comments · May be fixed by #324
Assignees
Labels
investigation issue requires investigation
Milestone

Comments

@CheatCod
Copy link
Member

CheatCod commented Jul 6, 2023

@Ynng I think I heard you mentioning why this is necessary, is it possible to remove this restriction?

@vadim-a-yegorov
Copy link

vadim-a-yegorov commented Jul 6, 2023

This issue occurs only on:

  • Electron (macOS Monterey 12.3.1 and Windows 10 tested)

@Ynng
Copy link
Member

Ynng commented Jul 6, 2023

This exists to simplify the setup process.

We assumed that if someone downloads the desktop client, they want to run a lodestone core locally.
If they only want to control remote cores they can just use the web app.

We can remove this, just gotta

  1. Add button to skip local core setup in Tauri
  2. Add button in core selection screen to setup local core so it can be setup later
  3. Track the skipped status so user won't be prompted again on restart of lodestone desktop

@Ynng Ynng added this to Lodestone Jul 13, 2023
@github-project-automation github-project-automation bot moved this to 🗃 Draft/Backlog in Lodestone Jul 13, 2023
@Ynng Ynng moved this from 🗃 Draft/Backlog to 🔖 Ready to Start in Lodestone Jul 20, 2023
@Ynng Ynng added this to the 0.5.0 milestone Jul 27, 2023
@jhuang38 jhuang38 linked a pull request Aug 1, 2023 that will close this issue
4 tasks
@Ynng Ynng moved this from 🔖 Ready to Start to 👀 In Review in Lodestone Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
investigation issue requires investigation
Projects
Status: 👀 In Review
Development

Successfully merging a pull request may close this issue.

4 participants