Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task page is non-responsive when there is a progression event #320

Closed
CheatCod opened this issue Jul 26, 2023 · 2 comments
Closed

Task page is non-responsive when there is a progression event #320

CheatCod opened this issue Jul 26, 2023 · 2 comments
Assignees
Labels
bug Something isn't working dashboard Issue for dashboard

Comments

@CheatCod
Copy link
Member

CheatCod commented Jul 26, 2023

Description

When there is a progression event being updated by a progression event, the entire macro page will freeze up (cannot click on buttons, switch between table views, etc)

Steps to reproduce (optional)

Run the following macro

import { ProgressionHandler } from "https://raw.githubusercontent.com/Lodestone-Team/lodestone-macro-lib/main/events.ts";

const progression = ProgressionHandler.create("title", null);
while (true) {
    // cycle through the animation state
    progression.addProgress(0, "test");
    // sleep for 200ms
    await new Promise((resolve) => setTimeout(resolve, 100));
}

Then try to interact with elements on the macro and task page

@CheatCod CheatCod added bug Something isn't working dashboard Issue for dashboard labels Jul 26, 2023
@github-project-automation github-project-automation bot moved this to 🗃 Draft/Backlog in Lodestone Jul 27, 2023
@Ynng Ynng self-assigned this Jul 27, 2023
@Ynng
Copy link
Member

Ynng commented Jul 27, 2023

Might be solved in #294

@CheatCod CheatCod assigned jhuang38 and Ynng and unassigned Ynng and jhuang38 Aug 10, 2023
Ynng added a commit that referenced this issue Aug 31, 2023
@Ynng
Copy link
Member

Ynng commented Aug 31, 2023

fixed in ca078b8

@Ynng Ynng closed this as completed Aug 31, 2023
@github-project-automation github-project-automation bot moved this from 🗃 Draft/Backlog to ✔ Done in Lodestone Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dashboard Issue for dashboard
Projects
Status: Done
Development

No branches or pull requests

3 participants