Add JMF flags to entities so JACK loads them properly

Fixes #49

Author: LogicAndTrick

Sledge.Formats.Map/Formats/JackhamerJmfFormat.cs

@@ -663,7 +663,17 @@ private static void WriteEntities(MapFile map, Dictionary<Group, JmfGroup> group
 
                 WriteString(ent.ClassName, bw);
                 bw.WriteVector3(ent.GetVectorProperty("origin", Vector3.Zero));
-                bw.Write(0); // flags
+
+                // JACK needs at least the PointBased flag. The others are likely optional
+                // but since we can derive most of them, might as well set them.
+                var flags = JmfFlags.None;
+                if (ent.Children.Count == 0) flags |= JmfFlags.PointBased;
+                if (ent.GetIntProperty("rendermode", 0) != 0) flags |= JmfFlags.RenderMode;
+                if (ent.ClassName == "worldspawn") flags |= JmfFlags.IsWorld;
+                if (ent.ClassName.StartsWith("weapon_") || ent.ClassName.StartsWith("item_")) flags |= JmfFlags.WeaponOrItem;
+                if (ent.ClassName.StartsWith("path_")) flags |= JmfFlags.PathEntity;
+                bw.Write((int)flags);
+
                 bw.Write(GetGroupID(groups, egr.Group));
                 bw.Write(GetGroupID(groups, egr.RootGroup));
                 bw.WriteRGBAColour(ent.Color);
@@ -903,10 +913,14 @@ private enum JmfRendering : int
         private enum JmfFlags
         {
             None = 0x00,
-            PointBased = 0x01,   // Or maybe 'HasOrigin'?
+            PointBased = 0x01,     // Or maybe 'HasOrigin'?
             Selected = 0x02,
             Hidden = 0x08,
-            RenderMode = 0x10,   // Any other render mode than 'normal'
+            RenderMode = 0x10,     // Any other render mode than 'normal'
+            IsWorld = 0x0020,      // The special "worldspawn" entity
+            WeaponOrItem = 0x0040, // Any entity whose name starts with "weapon" or "item_"
+            PathEntity = 0x0080,   // Any entity whose name starts with "path_"
+            Unknown1 = 0x8000,     // TODO: This appears to be related to models, and may have been introduced in a newer JACK version?
         }
     }
 }

Sledge.Formats.Map/Sledge.Formats.Map.csproj

@@ -4,15 +4,15 @@
     <TargetFramework>netstandard2.0</TargetFramework>
     <Authors>LogicAndTrick</Authors>
     <Description>Parsers for map source files used by level editors. Currently supports MAP files in the idtech2 and valve formats, Worldcraft RMF v2.2, and partial support for Source Hammer VMF and Jackhammer/JACK JMF formats.</Description>
-    <Copyright>2022 LogicAndTrick</Copyright>
+    <Copyright>2025 LogicAndTrick</Copyright>
     <PackageLicenseExpression>MIT</PackageLicenseExpression>
     <PackageProjectUrl>https://github.com/LogicAndTrick/sledge-formats</PackageProjectUrl>
     <PackageIcon>sledge-logo.png</PackageIcon>
     <RepositoryUrl>https://github.com/LogicAndTrick/sledge-formats</RepositoryUrl>
     <RepositoryType>Git</RepositoryType>
     <PackageTags>half-life quake valve hammer worldcraft jackhammer jack rmf vmf map jmf</PackageTags>
-    <PackageReleaseNotes>Update to System.Numerics.Vectors 4.6.1</PackageReleaseNotes>
-    <Version>1.2.7</Version>
+    <PackageReleaseNotes>Add JMF flags to entities so JACK loads them properly</PackageReleaseNotes>
+    <Version>1.2.8</Version>
 	<DebugType>full</DebugType>
 	<DebugSymbols>true</DebugSymbols>
   </PropertyGroup>