Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot replace em or rem with px #163

Open
TomSaporitoXO opened this issue Dec 20, 2018 · 2 comments
Open

Cannot replace em or rem with px #163

TomSaporitoXO opened this issue Dec 20, 2018 · 2 comments

Comments

@TomSaporitoXO
Copy link

I really think that you should add an alternative field to specify the unit for widths:
containerUnits: 'px'
And allow the xs md etc properties to accept pixels

@LoicMahieu
Copy link
Owner

Hi @TomSaporitoXO
Thanks for your first issue ever on Github ;)

Yep... maybe. But rem and em are well supported by modern browsers: https://caniuse.com/#feat=rem

I suggest you try to implement it and submit a pull request. We'll be able to discuss about that.

@windmaomao
Copy link

My main issue with it is how to do with percentage. For example, if i happen to have a padding in one div, then all the number in rem seems just stop working properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants