Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android availability #25

Open
ohhai opened this issue Jun 17, 2020 · 6 comments
Open

Android availability #25

ohhai opened this issue Jun 17, 2020 · 6 comments

Comments

@ohhai
Copy link

ohhai commented Jun 17, 2020

This extension seems working fine on Android, but addons.mozilla.org site tells that it's not for Android.
I had to point FF to the .xpi file directly.
Maybe just manifest file update needed?

Side request, might be worth of separate ticket: it would be great to see the (overall) tabs number in main menu of FF for Android. Currently it requires an extra click to see counters (and the new page affects counter by itself?).

@ohhai
Copy link
Author

ohhai commented Jun 17, 2020

Screenshot_2020-06-17-23-34-49

My screenshot with Ublock counter as example.

@Loirooriol
Copy link
Owner

I think in some case the add-on can use some API which was not available on Android, I don't remember much. Anyways I didn't really test it on Android since Firefox for Android has a native tab counter, which seemed to work fine. I didn't know it can only reach 99, I only have thousands of tabs on desktop.

Showing the number in the menu seems an improvement indeed.

@ohhai
Copy link
Author

ohhai commented Jun 17, 2020

If that is some desktop API - it should be something not related to main tab counting, since it works fine. I can try to check it, if FF for Android has some way to (enable remote debugging and search for errors?:)

@Loirooriol
Copy link
Owner

OK, so the browser.windows API doesn't work. I guess that's why you don't see the number of tabs in the menu, that's probably the title or the badge, but the background script is not working correctly. browser.windows is also used in the windowId polyfill, but I should just remove it since it has been quite some time since I implemented windowId in Firefox.

@ohhai
Copy link
Author

ohhai commented Jun 17, 2020

Sounds reasonable, I'm not sure if it's possible to have windows number > 1 for Android (excluding private mode maybe).

@Loirooriol
Copy link
Owner

No, android has a single internal window. It's just the UI that makes it look like there are two of them. So to be consistent, I guess the add-on would need to query the tabs with the same incognito state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants