Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build under Windows is flaky and PNPM frequently fails (OSOE-959) #162

Open
Piedone opened this issue Dec 30, 2024 · 6 comments
Open

Build under Windows is flaky and PNPM frequently fails (OSOE-959) #162

Piedone opened this issue Dec 30, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@Piedone
Copy link
Member

Piedone commented Dec 30, 2024

The CI build under Windows, but not under Ubuntu, frequently fails with the following error:

Starting to execute tests from the C:\a\Open-Source-Orchard-Core-Extensions\Open-Source-Orchard-Core-Extensions\test\Lombiq.UITestingToolbox\Lombiq.Tests.UI.Samples\Lombiq.Tests.UI.Samples.csproj project.
Starting testing with `dotnet test --configuration Debug --nologo --logger 'trx;LogFileName=test-results.trx' --logger 'console;verbosity=detailed' --verbosity quiet  --filter 'FullyQualifiedName!~SecurityScanningTests&FullyQualifiedName!~BehaviorElasticsearchTests'  C:\a\Open-Source-Orchard-Core-Extensions\Open-Source-Orchard-Core-Extensions\test\Lombiq.UITestingToolbox\Lombiq.Tests.UI.Samples\Lombiq.Tests.UI.Samples.csproj`.
C:\a\Open-Source-Orchard-Core-Extensions\Open-Source-Orchard-Core-Extensions\src\Modules\Lombiq.VueJs\Lombiq.VueJs\Lombiq.VueJs.csproj(82,5): error MSB3073: The command "npm explore nodejs-extensions -- pnpm build" exited with code 1.

This needs to be investigated with a more verbose log.

When rebuilding the whole solution from VS locally, the following can happen:

48>> SRC=$(node scripts/get-path js source) DEST=$(node scripts/get-path js target) && if-env SRC=! && echo "Skipping scripts" && exit 0 || node scripts/compile-scripts "$SRC" "$DEST" "${INIT_CWD}/config/" || AREA=scripts STEP=compilation pnpm error
48>
48>
53>
53>no-path(1,1): error ERROR: No files matching the pattern "" were found.
53>
53>EXEC : > [email protected] error E: \ShortPath\OSOCE1\node_modules\.nx
53>> echo "Error in $AREA pipeline: $STEP failed."
53>
53>Error in styles pipeline: linting failed.
53>E:\ShortPath\OSOCE1\src\Modules\Lombiq.VueJs\Lombiq.VueJs\Lombiq.VueJs.csproj(82,5): error MSB3073: The command "npm explore nodejs-extensions -- pnpm build" exited with code -1.
53>Done building project "Lombiq.VueJs.csproj" -- FAILED.

Jira issue

@Piedone Piedone added the bug Something isn't working label Dec 30, 2024
@github-actions github-actions bot changed the title Build under Windows is flaky and PNPM frequently fails Build under Windows is flaky and PNPM frequently fails (OSOE-959) Dec 30, 2024
@Piedone
Copy link
Member Author

Piedone commented Dec 31, 2024

Will be part of #160.

@Piedone
Copy link
Member Author

Piedone commented Jan 29, 2025

This is an issue even with the current dev, without any package updates. A recent example, with build verbosity increased to minimal, is here: https://github.com/Lombiq/Open-Source-Orchard-Core-Extensions/actions/runs/13020677548/job/36320766280 However, details are the same as above.

Attaching the binary log if it may be helpful.

build-binary-log-.-Windows-X64-windows-2022-8core_a1ee65c8efff.binlog.zip

Adding such styles section despite there not being any stylesheets might be a workaround:

    "styles": {
      "source": "Assets/Styles",
      "target": "wwwroot/css"
    }

I added this in #164.

This might be a bug in Node.js Extensions.

@Piedone Piedone reopened this Jan 29, 2025
@Piedone
Copy link
Member Author

Piedone commented Jan 29, 2025

@sarahelsaig if you're interested.

@sarahelsaig
Copy link
Member

Is this a Windows-specific problem? I'm not too eager for issues where I'd have to stop doing everything else and reboot into Windows.

@Piedone
Copy link
Member Author

Piedone commented Jan 29, 2025

I'm not entirely sure, but that's where I only remember it seeing. However, judging from the error message and the workaround, this seems more like a circumstantial bug, possibly only happening under Windows because those builds are slower.

@Piedone
Copy link
Member Author

Piedone commented Feb 10, 2025

The above-mentioned workaround seems to have fixed it. This needs to work properly without that, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants