Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Failed download attachments after starting for a period of time #166

Open
niuhuan opened this issue Feb 22, 2023 · 1 comment
Open

Comments

@niuhuan
Copy link
Contributor

niuhuan commented Feb 22, 2023

Because FileDownloader does not have the ability to reconnect

I tried delete this line codes, then this bug has been fixed.

mutex.insert(dc_id, new_downloader.clone());

This line of code is for multiple downloads to use one Downloader, If delete this line, a new Downloader will be generated each time.

The code is dirty, and my code quality is not good. It may take a long time. At the same time, I hope others can repair it.

Icreate a new issue and record it first.

@gus4rs
Copy link
Contributor

gus4rs commented Feb 22, 2023

The workaround works because it creates a new downloader on every download, which is wasteful. A solution is to only re-create the downloader if it is disconnected, reuse it otherwise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants