Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark Mode #59

Closed
1 of 3 tasks
mattloose opened this issue Oct 6, 2024 · 1 comment · Fixed by #66
Closed
1 of 3 tasks

Dark Mode #59

mattloose opened this issue Oct 6, 2024 · 1 comment · Fixed by #66
Assignees
@mattloose

Comments

@mattloose
Copy link
Contributor

mattloose commented Oct 6, 2024 •
edited
Loading

If we are going to have dark mode it should - at least - work...

  • check each page for correct dark mode performance
  • check each graph for readability
  • remove shadow styling where appropriate
@mattloose mattloose self-assigned this Oct 6, 2024
@mattloose
Copy link
Contributor Author

Dark mode is checked on each page as of #fix/darkmode

Graph readability is more complex and is challenging in nicegui currently - see zauberzeug/nicegui#3753 (comment) for some further discussion of tailwind issues in dark mode.

@mattloose mattloose linked a pull request Oct 13, 2024 that will close this issue
Fix/darkmode #66
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattloose mattloose

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/darkmode LooseLab/ROBIN
1 participant
@mattloose