Merge pull request #29 from Liamb17/3.x

fix: check driver is Cake Driver before trying to access
LordSimal · Dec 29, 2024 · ecdbd4b · ecdbd4b
2 parents cf4305d + 1a8f49e
commit ecdbd4b
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 9 deletions.
diff --git a/src/Http/SentryClient.php b/src/Http/SentryClient.php
@@ -4,6 +4,7 @@
 namespace CakeSentry\Http;
 
 use Cake\Core\Configure;
+use Cake\Database\Driver;
 use Cake\Datasource\ConnectionManager;
 use Cake\Error\PhpError;
 use Cake\Event\Event;
@@ -53,13 +54,17 @@ protected function getQueryLoggers(): void
         $includeSchemaReflection = (bool)Configure::read('CakeSentry.includeSchemaReflection');
 
         foreach ($configs as $name) {
+            $logger = null;
             $connection = ConnectionManager::get($name);
             if ($connection->configName() === 'debug_kit') {
                 continue;
             }
             /** @var \Cake\Database\Driver $driver */
             $driver = $connection->getDriver();
-            $logger = $driver->getLogger();
+
+            if ($driver instanceof Driver) {
+                $logger = $driver->getLogger();
+            }
 
             if ($logger instanceof CakeSentryLog) {
                 $logger->setIncludeSchema($includeSchemaReflection);

diff --git a/src/Middleware/CakeSentryPerformanceMiddleware.php b/src/Middleware/CakeSentryPerformanceMiddleware.php
@@ -13,6 +13,7 @@
  */
 namespace CakeSentry\Middleware;
 
+use Cake\Database\Driver;
 use Cake\Datasource\ConnectionManager;
 use Cake\Event\EventManager;
 use Cake\Http\Server;
@@ -121,11 +122,13 @@ protected function addQueryData(): void
             $logger = null;
             /** @var \Cake\Database\Driver $driver */
             $driver = $connection->getDriver();
-            $driverConfig = $driver->config();
-            if ($driverConfig['sentryLog'] ?? false) {
-                $logger = $driver->getLogger();
-                if ($logger instanceof CakeSentryLog) {
-                    $logger->setPerformanceMonitoring(true);
+            if ($driver instanceof Driver) {
+                $driverConfig = $driver->config();
+                if ($driverConfig['sentryLog'] ?? false) {
+                    $logger = $driver->getLogger();
+                    if ($logger instanceof CakeSentryLog) {
+                        $logger->setPerformanceMonitoring(true);
+                    }
                 }
             }
         }

diff --git a/src/Middleware/CakeSentryQueryMiddleware.php b/src/Middleware/CakeSentryQueryMiddleware.php
@@ -14,6 +14,7 @@
 namespace CakeSentry\Middleware;
 
 use Cake\Core\Configure;
+use Cake\Database\Driver;
 use Cake\Datasource\ConnectionManager;
 use CakeSentry\Database\Log\CakeSentryLog;
 use Psr\Http\Message\ResponseInterface;
@@ -59,9 +60,11 @@ protected function enableQueryLogging(): void
             $logger = null;
             /** @var \Cake\Database\Driver $driver */
             $driver = $connection->getDriver();
-            $driverConfig = $driver->config();
-            if ($driverConfig['sentryLog'] ?? false) {
-                $logger = $driver->getLogger();
+            if ($driver instanceof Driver) {
+                $driverConfig = $driver->config();
+                if ($driverConfig['sentryLog'] ?? false) {
+                    $logger = $driver->getLogger();
+                }
             }
 
             $logger = new CakeSentryLog($logger, $name, $includeSchemaReflection);