Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Return early when elastic search provides no query object #32

Merged
merged 2 commits into from
Dec 30, 2024

Conversation

Liamb17
Copy link
Contributor

@Liamb17 Liamb17 commented Dec 30, 2024

Elasticsearch does not return a LoggedQuery object when performance tracking is enabled.

Currently results in a fatal error being produced - This PR fixes that.

To track the Elasticsearch queries this would need a major refactoring.

@LordSimal LordSimal merged commit 9c4d4fe into LordSimal:3.x Dec 30, 2024
7 of 8 checks passed
@LordSimal
Copy link
Owner

Thanks, release is now out there.

Also for the next time: You can execute composer cs-fix, composer cs-check and composer stan to get the last CI step to green 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants