Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High level question #1

Open
kirs opened this issue Jan 12, 2019 · 1 comment
Open

High level question #1

kirs opened this issue Jan 12, 2019 · 1 comment

Comments

@kirs
Copy link

kirs commented Jan 12, 2019

Love the gem! Some high level questions:

  • Have you considered using ActiveJob? It allows you to define n generic job that works with any underlying adapter (Sidekiq, DelayedJob etc). By using it you could reduce any adapter-specific things and potentially have less code in the gem.

  • The job runs async only when turn_async is called at the top of migration class. Having two ways to run a migration can be confusing for developers, as now they need to keep in mind two queues (sync and async, what you describe in the README). Are there are legit use cases when you do NOT want the migration to be async? If not, could we make it simpler for developers by making all migrations async by default, without need to call anything at the top of the class?

@takanabe
Copy link

takanabe commented Oct 16, 2019

@Loschcode

I completely understand the motivation since I encountered the scaling problem situations sometimes and I considered implementing this kind of an async migration support gem.

I have exactly the same questions which @kirs had when I walked through README. Could you answer the questions? If you don't have time to change this gem, I may send PRs to improve based on your answers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants