Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.18.1] Spells do not respect other mods' methods of detecting and preventing player damage to own pets #69

Open
Not-February opened this issue Jan 22, 2022 · 1 comment
Labels

Comments

@Not-February
Copy link

Minecraft version & Mod Version: Minecraft 1.18.1, Roots Classic 1.1.16

Single player or Server: Single player

Describe problem (what you were doing / what happened): I consider this a significant problem primarily because of mod interactions. It's uncomfortably easy to harm creatures you don't want to harm(like your pets) even if you have a mod installed that generally blocks you from damaging your own pets, for example.

I tried this with Mahou Tsukai's Geas spell active(which prevents you from damaging specified entities) as well as Enigmatic Legacy's Guide to Animal Companionship(which is meant to prevent you from dealing damage to any animals while it is in your inventory), and neither method prevented my own pets from being hurt when I used a spell near them.

@Mrbysco Mrbysco added the 1.18 label Jun 9, 2022
Mrbysco added a commit that referenced this issue Sep 14, 2022
Specify the one who casted the spell during spells that can harm mobs (Hopefully fixing #69)
Improve component code
@Mrbysco
Copy link
Collaborator

Mrbysco commented Sep 14, 2022

In 1.19 I've added entity context to the spells that can harm mobs which should give enough context for mods to cancel the attack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants