Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No randomness is added during the sampling process? #49

Open
PANG-98 opened this issue Jan 14, 2024 · 2 comments
Open

No randomness is added during the sampling process? #49

PANG-98 opened this issue Jan 14, 2024 · 2 comments

Comments

@PANG-98
Copy link

PANG-98 commented Jan 14, 2024

Hey fellows, really good work and thanks for sharing the code. However, I've got a question about the sampling process. It seems like no randomness is added during the sampling process, like the z in the following equation.
image
I've checked the code and it seems like add_noise function defined in DPM_Solver class has never been used. Why is the case? Could you very kindly explain this? Thanks!

@LuChengTHU
Copy link
Owner

Because DPM-Solver is an ODE-based solver so it does not add noises at the intermediate steps. I also implemented SDE-based DPM-Solver here: https://huggingface.co/docs/diffusers/en/api/schedulers/multistep_dpm_solver

@PANG-98
Copy link
Author

PANG-98 commented Mar 11, 2024

Because DPM-Solver is an ODE-based solver so it does not add noises at the intermediate steps. I also implemented SDE-based DPM-Solver here: https://huggingface.co/docs/diffusers/en/api/schedulers/multistep_dpm_solver

Thanks for your reply. Any preference for these two implementation? which one is more accurate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants