Replies: 2 comments 9 replies
-
|
From the codebase,
🤔 Can't you just write the config as the following? {
"workspace.library": [ "/usr/share/lua/5.4" ],
"workspace.ignoreDir": [ "<mymodule>" ]
}or is it because your current working directory also contains a |
Beta Was this translation helpful? Give feedback.
-
|
@tomlau10 hmm... I thought about this and I am unsure. I bet there would be a way to detect absolute paths in On the other hand this would be a simple and elegant fix for my issue. I am also thinking about the portability problem of any What do you think? |
Beta Was this translation helpful? Give feedback.
-
|
@sewbacca I put our discussion into sonnet4 and here is its reply 👀 Sonnet4's reply
In short, the Per library config
|
Beta Was this translation helpful? Give feedback.
-
|
@tomlau10 I haven't tested it yet, but absolute paths on windows start with We also could simply check if the prefix matches a library path and if it does, use the suffix (skipping an initial directory seperator) as a gitignore pattern. You'd need to do this check from longest library paths to the shortest though to be unambiguous. I'm not sure if it is necessary, though. Ideally this check should only be performed if the path is absolute (starts with slash inclusive-or on windows starts with a letter colon directory separator). This would be more akin my first proposal. I agree though that fixing it in P.S. I understand that everybody is using AI nowadays and at times it really is a good tool. However I am not particularly happy that you fed our discussion to an AI. I appreciate your transparency though. |
Beta Was this translation helpful? Give feedback.
-
@sewbacca Yes, you're right. Windows' paths containing a Maybe we should just do best effort support, and at most add some special detection on the path
New Patch and testingNew Patch
From c4b31ee522a451df450fca5b9be96908f5a7cb88 Mon Sep 17 00:00:00 2001
From: Tom Lau <[email protected]>
Date: Tue, 1 Jul 2025 10:36:02 +0800
Subject: [PATCH] feat: support per library ignoreDir in format
`{library}:{path}`
---
script/workspace/workspace.lua | 28 +++++++++++++++++++++++-----
1 file changed, 23 insertions(+), 5 deletions(-)
diff --git a/script/workspace/workspace.lua b/script/workspace/workspace.lua
index d5868342..40d25dc1 100644
--- a/script/workspace/workspace.lua
+++ b/script/workspace/workspace.lua
@@ -210,6 +210,7 @@ function m.getLibraryMatchers(scp)
log.debug('Build library matchers:', scp)
local pattern = {}
+ local libraryPattern = {}
for path, ignore in pairs(config.get(scp.uri, 'files.exclude')) do
if ignore then
log.debug('Ignore by exclude:', path)
@@ -218,29 +219,46 @@ function m.getLibraryMatchers(scp)
end
for _, path in ipairs(config.get(scp.uri, 'Lua.workspace.ignoreDir')) do
log.debug('Ignore directory:', path)
- pattern[#pattern+1] = path
+ if path:find(':', 3, true) then
+ -- this is a "{library}:{path}" which only applies to specfic library path
+ local libraryPath, subPath = path:match("(.+):(.+)")
+ libraryPath = libraryPath and m.getAbsolutePath(scp.uri, libraryPath)
+ if libraryPath ~= nil then
+ libraryPath = files.normalize(libraryPath)
+ libraryPattern[libraryPath] = libraryPattern[libraryPath] or {}
+ table.insert(libraryPattern[libraryPath], subPath)
+ end
+ else
+ pattern[#pattern+1] = path
+ end
end
+ ---@type table<string, string[]> # { [libraryPath] = ignorePattern[] }
local librarys = {}
for _, path in ipairs(config.get(scp.uri, 'Lua.workspace.library')) do
path = m.getAbsolutePath(scp.uri, path)
if path then
- librarys[files.normalize(path)] = true
+ local libraryPath = files.normalize(path)
+ if libraryPattern[libraryPath] then
+ -- merge default pattern[] to libraryPattern
+ util.arrayMerge(libraryPattern[libraryPath], pattern)
+ end
+ librarys[libraryPath] = libraryPattern[libraryPath] or pattern
end
end
local metaPaths = scp:get 'metaPaths'
log.debug('meta path:', inspect(metaPaths))
if metaPaths then
for _, metaPath in ipairs(metaPaths) do
- librarys[files.normalize(metaPath)] = true
+ librarys[files.normalize(metaPath)] = pattern
end
end
local matchers = {}
- for path in pairs(librarys) do
+ for path, patterns in pairs(librarys) do
if fs.exists(fs.path(path)) then
local nPath = fs.absolute(fs.path(path)):string()
- local matcher = glob.gitignore(pattern, {
+ local matcher = glob.gitignore(patterns, {
root = path,
ignoreCase = platform.os == 'windows',
}, globInteferFace)
--
2.47.1.windows.2
{
"workspace.library": ["C:\\Users\\TomLau\\lib"],
"workspace.ignoreDir": ["C:\\Users\\TomLau\\lib:mylib"]
}
I am not sure if this is 100% correct, because the initial directory separator has meaning in gitignore pattern, which means restrict this only to the (root) directory and not in its subdirectories 😕
I'm sorry about that. 😓 |
Beta Was this translation helpful? Give feedback.
-
There are not. I don't like that AI companies are using the work of people, be it code, art or simply ideas, supplied for free use to other human beings in order to train their models without the creators permission and without compensating them while making millions. This is however mostly your work, I just threw in some ideas, so for me it's up to you what you wanna share and what you don't. I find it good practice in general to hide identifiable information as much as possible from a privacy first mindset though. |
Beta Was this translation helpful? Give feedback.
-
Here's another attempt, using your idea of "matching library path prefix" 🤔
This seems to be working well in my testing config above 👀 {
"workspace.library": [ "C:\\Users\\TomLau\\lib" ],
"workspace.ignoreDir": ["C:\\Users\\TomLau\\lib\\mylib"]
}
{
"workspace.library": [ "..\\lib" ],
"workspace.ignoreDir": ["..\\lib\\mylib"]
}
The Patch
From badeaf481e1742b727b850b59707c4b00d3365d5 Mon Sep 17 00:00:00 2001
From: Tom Lau <[email protected]>
Date: Thu, 3 Jul 2025 09:46:00 +0800
Subject: [PATCH] feat: support per library ignoreDir when library path prefix
matched
---
script/workspace/workspace.lua | 30 ++++++++++++++++++++++++++++--
1 file changed, 28 insertions(+), 2 deletions(-)
diff --git a/script/workspace/workspace.lua b/script/workspace/workspace.lua
index d5868342..bcce69f8 100644
--- a/script/workspace/workspace.lua
+++ b/script/workspace/workspace.lua
@@ -216,9 +216,27 @@ function m.getLibraryMatchers(scp)
pattern[#pattern+1] = path
end
end
+ local libraryPatterns = {}
for _, path in ipairs(config.get(scp.uri, 'Lua.workspace.ignoreDir')) do
log.debug('Ignore directory:', path)
- pattern[#pattern+1] = path
+ -- check for library specific ignoreDir
+ local isLibrarySpecific = false
+ for _, libraryPath in ipairs(config.get(scp.uri, 'Lua.workspace.library')) do
+ if path:sub(1, #libraryPath) == libraryPath then
+ -- prefix matched, remove the prefix
+ local subPath = path:sub(#libraryPath+1)
+ local absLibraryPath = m.getAbsolutePath(scp.uri, libraryPath)
+ if absLibraryPath then
+ isLibrarySpecific = true
+ local libraryPathKey = files.normalize(absLibraryPath)
+ libraryPatterns[libraryPathKey] = libraryPatterns[libraryPathKey] or {}
+ table.insert(libraryPatterns[libraryPathKey], subPath)
+ end
+ end
+ end
+ if not isLibrarySpecific then
+ pattern[#pattern+1] = path
+ end
end
local librarys = {}
@@ -239,8 +257,16 @@ function m.getLibraryMatchers(scp)
local matchers = {}
for path in pairs(librarys) do
if fs.exists(fs.path(path)) then
+ local patterns = libraryPatterns[path]
+ if patterns then
+ -- append default pattern
+ util.arrayMerge(patterns, pattern)
+ else
+ -- use default pattern
+ patterns = pattern
+ end
local nPath = fs.absolute(fs.path(path)):string()
- local matcher = glob.gitignore(pattern, {
+ local matcher = glob.gitignore(patterns, {
root = path,
ignoreCase = platform.os == 'windows',
}, globInteferFace)
--
2.47.1.windows.2
|
Beta Was this translation helpful? Give feedback.
-
|
I haven't tested that either, but shouldn't there be a check if prefix+1 is a directory separator (either forward or backward slash)? In my mind this solution is more intuitive, but your other solution is more flexible. I think I'd be happy if we merge the two. Have the intuitive ignore an absolute directory, but if an all subdirectory check is wanted, |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Is there a way to specify absolute paths in
"workspace.ignoreDir"? I tried a lot and cant quite figure it out.I have two use cases. First: When developing a LuaRocks module I get always duplicate symbols after installing my module locally and developing it at the same time.
What I currently do is this:
{ "workspace.library": [ "/usr/share/lua" ], "runtime.path": [ "5.4/?.lua", "5.4/?/init.lua" ], "workspace.ignoreDir": [ "5.4/<mymodule>", "5.1/<mymodule>" ] }This works fine, however it would be nicer to not load all lua versions and instead load
"/usr/share/lua/5.4"directly, while ignoring only the directory"/usr/share/lua/5.4/<mymodule>".For my other use-case I have some scripts lying around where there are many sub directories. Maybe I have a root file called
scan.luaor something like that, and I just want to get modules from the LuaRocks tree, but not from any the sub-directories. The following config does not work as intended.{ "workspace.library": [ "/usr/share/lua" ], "runtime.path": [ "5.4/?.lua", "5.4/?/init.lua" ], "workspace.ignoreDir": [ "*", "!5.4", "!scan.lua" ] }This doesn't work as my require path never finds the modules from the luarocks tree. If I remove the
"*"from"workspace.ignoreDir"then it does find the require paths, but it will also search all the sub-directories.So is there a way to specify an absolute path in
"workspace.ignoreDir"? Or do you have another workaround I haven't thought of?Thanks in advance =)
Beta Was this translation helpful? Give feedback.
All reactions