Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should I install fastclick by myself? #130

Open
mrdulin opened this issue Jan 19, 2018 · 3 comments
Open

Should I install fastclick by myself? #130

mrdulin opened this issue Jan 19, 2018 · 3 comments

Comments

@mrdulin
Copy link

mrdulin commented Jan 19, 2018

I do not see fastclick list on devDependencies of package.json .

Should I install fastclick by myself? Or, just add alias 'react-tap-event-plugin': 'react-lite/lib/react-tap-event-plugin'?

react-lite/lib/react-tap-event-plugin.js:

'use strict';

var Fastclick = require('fastclick');
module.exports = function injectTapEventPlugin() {
	var supportTouch = ('ontouchstart' in document);
	if (supportTouch) {
		Fastclick.attach(document.body);
	}
};
@Lucifier129
Copy link
Owner

yes, npm install --save fastclick is necessary when use react-lite/lib/react-tab-event-plugin.

@mrdulin
Copy link
Author

mrdulin commented Jan 19, 2018

@Lucifier129 Why don't include fastclick as react-lite dependency?

@Lucifier129
Copy link
Owner

@mrdulin react-lite/lib/react-tab-event-plugin is not the normal usage of react-lite, I think it's better to keep independent in package.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants