Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using source generator #2

Open
glennawatson opened this issue Dec 24, 2021 · 1 comment
Open

Consider using source generator #2

glennawatson opened this issue Dec 24, 2021 · 1 comment

Comments

@glennawatson
Copy link

At the moment parts of your code base are using reflection to register your dialogs. eg

vm = Type.GetType($"{exportedType.FullName}ViewModel, {exportedType.Assembly.FullName}");

Consider using source generator similar to https://github.com/reactivemarbles/Splat.DI.SourceGenerator

Main advantage is performance.

Also the reflection code is a bit manual which can cause a bit of breakage easily

@glennawatson
Copy link
Author

So with source generators btw, the actual code you produce isn't all that different, just you know the types at compile time and generate the code then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant