Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Codespace incompatibility #398

Open
ishapiro opened this issue Mar 13, 2024 · 2 comments
Open

Github Codespace incompatibility #398

ishapiro opened this issue Mar 13, 2024 · 2 comments

Comments

@ishapiro
Copy link
Collaborator

Lumibot models execute well using the 4 core (36 cents per hour -- 30 hours free per month) - GitHub Codespaces. Using the 2 core Codespaces, they work but run slowly. The 4 code spaces run Lumibot almost as fast as my Macbook Pro M1 MAX. I access the CodeSpace from a very slow Surface Go 4 and this allows me to do work when on the road from a laptop that is under 1.5 lbs.

When running a backtest in the GitHub Codespace environment, using the browser-based IDE, the Codespace crashes when Lumibot attempts to open a browser window to display any of the HTML files. Currently, the options "show_indicators", "show_tearsheet", and, "show_plot" suppress both the display and the creation of the HTML files. The "save_*" options do not seem to work correctly, and there is no "save_indicators" option.

Long term it would be optimal for the open HTML option to be compatible with GitHub Codespaces. In the short term, it would be great if there were "save_*" options for all of the HTML files that worked properly.

Note: when accessing a Codespace from a local copy of VS Code instead of the browser-based VS Code, this is not an issue.

@grzesir
Copy link
Contributor

grzesir commented Mar 17, 2024

I believe this has been completed fully. @ishapiro can you confirm?

@ishapiro
Copy link
Collaborator Author

Unfortunately, it is not complete. The following options for showing HTML files are now available. However, when some of these options are set to False, the corresponding HTML files are not saved.

show_plot: bool
show_tearsheet: bool
show_indicators: bool

This can be remedied by supporting save_plot, save_tearsheet and save_indications. That way, you can produce all HTML files without forcing them to be displayed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants