Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email improvements #169

Open
4 of 8 tasks
bmyerz opened this issue Aug 5, 2020 · 2 comments
Open
4 of 8 tasks

Email improvements #169

bmyerz opened this issue Aug 5, 2020 · 2 comments
Assignees

Comments

@bmyerz
Copy link
Contributor

bmyerz commented Aug 5, 2020

do this all on localhost only

  • when running on flask server localhost email button should behave in a way simulates the expected behavior. When you click it, it should turn to the sending icon and after a delay of 10seconds it should say Emails Sent.
  • fix: first time you go to the page it already says Emails Are Sent!
  • fix: after clicking Email button, it seems to hang on "Sending..." forever
  • on localhost instead of sending actual emails, generate them and save them as files.

second steps

  • Test emails on dev server to ensure working properly

Lower priority

  • add button next to Email that says Download student feedback forms (so instructor can distribute them another way or simply look at a sample feedback form)
  • Test: Do emails get sent to all teams or only those who have been rated for this evaluation?
  • progress bar instead of spinning
@bmyerz
Copy link
Contributor Author

bmyerz commented Aug 5, 2020

closing #146 in favor of this one

@bmyerz bmyerz closed this as completed Aug 5, 2020
@bmyerz bmyerz reopened this Aug 5, 2020
@bmyerz
Copy link
Contributor Author

bmyerz commented Oct 14, 2020

tracking this issue in PR #201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants