Clean up command factory #3431
Clean up command factory #3431
Conversation
|
Documentation has been published to https://lundalogik.github.io/lime-elements/versions/PR-3431/ |
john-traas
force-pushed
the
clean-up-command-factory
branch
2 times, most recently
from
48cb384 to
c6a8a28
Compare
john-traas
force-pushed
the
clean-up-command-factory
branch
from
c6a8a28 to
24b1710
Compare
adrianschmidt
force-pushed
the
main
branch
3 times, most recently
from
197298f to
a0e1088
Compare
- Move functionality out to separate util files
- move test files into separate folder
There was a problem hiding this comment.
Why move tests into a folder called __tests__? Is that a prosemirror convention? Because we don't use that pattern anywhere else in lime-elements… 🧐
There was a problem hiding this comment.
Ah... The initial folder/file was generated by cursor when I had it help me setup the boilerplate for the tests. We should follow the normal pattern we use and have the tests alongside the files they are testing.
|
If you try to make sub-lists, the behaviour quickly gets quite weird 🤔 Screen.Recording.2025-02-15.at.22.05.14.mov |
adrianschmidt
force-pushed
the
clean-up-command-factory
branch
from
ed54b1f to
fba00f3
Compare
I think I have some ideas of why this is happening. I'll take a look again on Monday. |
|
Yeah, I don't expect you to be working on the weekend just because I am 😂 No stress my friend! 🤗 |
john-traas
force-pushed
the
clean-up-command-factory
branch
from
fbe44da to
8eb4802
Compare
- instead of trying to convert nested list nodes and creating extra transactions we limit functionality
john-traas
force-pushed
the
clean-up-command-factory
branch
from
8eb4802 to
07b8313
Compare
This PR adds utility functions that use built in functions from prosemirror to handle operations related to creating/removing and toggling between list types in the text editor.
Tests are also added for this functionality.
Fixes: #3313