Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looking for Maintainers and Reviewers #102

Open
Lusito opened this issue Jul 21, 2024 · 3 comments
Open

Looking for Maintainers and Reviewers #102

Lusito opened this issue Jul 21, 2024 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@Lusito
Copy link
Owner

Lusito commented Jul 21, 2024

Hi everyone,

The code of webextension-polyfill and everything that is related is split over multiple projects:

  • the polyfill itself (maintained by mozilla)
  • The schema files from mozilla, which define what APIs are part of the official webextension API:
  • this project for generating the type definitions
  • the package @types/webextension-polyfill, which is published by DefinitelyTyped
  • The various browsers that implement the webextension APIs

I am currently the only maintainer of this project and I am the only "owner" for @types/webextension-polyfill and therefore it can be hard to find a reviewer on DefinitelyTyped pull-requests that understands the issues at hand.

The latest PR has been in review hell, with reviewers requesting changes and then ignoring the PR after I've replied. After almost 2 months I've just closed the PR and recreated it in the hope, that this time will be better.

I am currently asking Mozilla if it would be possible to include the types in the original package, but as that project is a rather slow moving/low maintenance project, I am not sure if they have the budget.

So in case that doesn't work out, I was wondering if someone might be interested in one or more of these tasks:

  • Regularly regenerating the code from schemas to see if something changes
  • Then create a PR on this project and later on DefinitelyTyped to get the changes published
  • Reviewing PRs on DefinitelyTyped, so they get published faster
@Lusito Lusito added the help wanted Extra attention is needed label Jul 21, 2024
@Rob--W
Copy link

Rob--W commented Aug 1, 2024

Note: in the addons-linter project, we also regularly import schemas from Firefox's source code. This is automated, and currently executed manually. We are considering to add a Github action to automatically schedule the import. I've described the task and referenced relevant documentation at mozilla/addons-linter#5388

And thanks for maintaining this. Reading this made me think of

XKCD 2347: Dependency

@mnoorenberghe
Copy link
Collaborator

Regularly regenerating the code from schemas to see if something changes
Then create a PR on this project and later on DefinitelyTyped to get the changes published
Reviewing PRs on DefinitelyTyped, so they get published faster

@Lusito I've done most of these occasionally in the past (examples: 1 2 3) (this time I was beat to updating the schema by a few days) so would be willing to do these going forward. I actively use the types in a production project and I previously worked on Firefox at Mozilla so am also comfortable submitting upstream bug fixes to the types.

@Lusito
Copy link
Owner Author

Lusito commented Aug 17, 2024

@mnoorenberghe Thanks. I've added you as a collaborator. Not sure what you are able to do with that exactly, but since this project has no publishing configured and the types are published on DT, I don't see much risk there. Just don't rewrite history, so no force-push on the master branch please.

Feel free to add yourself as an owner to the next DT PR (package.json on DT)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants