test: re-enable flux testing #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark Results (ASV)
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
avik-pal
force-pushed
the
ap/flux_testing
branch
from
6089c4a to
605dd7b
Compare
avik-pal
force-pushed
the
ap/flux_testing
branch
from
5c3fbfb to
858ef12
Compare
|
@avik-pal we need a release with this branch to successfully test Optimisers v0.4 in SciML/Optimization.jl#861 - this is holding back Flux which is holding back Optimisers in the resolver there |
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1070
This pull request includes several changes to the
LuxFluxExt.jland test files to re-enable previously disabled functionality and update test configurations. The most important changes are grouped by theme below:Test Configuration:
Fluxpackage in theEXTRA_PKGSlist intest/runtests.jl.skipcondition from theFromFluxAdaptortest item intest/transform/flux_tests.jl, allowing the test to run.