Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triton 3 wheels published for Windows #953

Open
liujvnes opened this issue Oct 15, 2024 · 8 comments
Open

Triton 3 wheels published for Windows #953

liujvnes opened this issue Oct 15, 2024 · 8 comments
Labels
enhancement New feature or request

Comments

@liujvnes
Copy link

Proposal

As seen here
https://www.reddit.com/r/StableDiffusion/comments/1g45n6n/triton_3_wheels_published_for_windows_and_working/

Comfy could get a 24% speed benefit, should we try the pull or not?
Thank you.

@liujvnes liujvnes added the enhancement New feature or request label Oct 15, 2024
@shivshankar11
Copy link

shivshankar11 commented Oct 15, 2024

It seems the Python installed by StabilityMatrix is an incomplete installation, and it lacks distutils. Please ask the authors of StabilityMatrix to fix that.

btw why stablitymatrix replace venv created with python 3.11. i want to use existing venv when using with stablity matrix.

Copy link

This issue is stale because it has been open 30 days with no activity. Remove the stale label or comment, else this will be closed in 5 days.

@github-actions github-actions bot added the stale Stale issue or inactive for long period of time label Nov 15, 2024
@pupphelper
Copy link

This is becoming a problem with many of the new video generaiton models requiring triton and sage. It would be great to be able to leverage the comfyUI in stable diffusion.

@mohnjiles mohnjiles removed the stale Stale issue or inactive for long period of time label Jan 5, 2025
@DmytroSokhach
Copy link

I think those issues are related: #954 and #801
I use StabilityMatrix for 2 years and don't want to drop 🥹
Also found this issue from Reddit thread (see below):
https://www.reddit.com/r/StableDiffusion/comments/1iz8npm/comment/mf1uran/?utm_source=share&utm_medium=web3x&utm_name=web3xcss&utm_term=1&utm_content=share_button

Q: Is there any roadmap on updated/compatible Python version?

Image

@mohnjiles
Copy link
Contributor

There's nothing stopping you from installing pre-built wheels from the link above. Download the Python 3.10 version, open the Python Packages dialog, click the + button, and enter the path to the file you downloaded:

Image

Congrats, Triton is now installed in whichever webUI you chose.

Q: Is there any roadmap on updated/compatible Python version?

We are working on it. It's not as easy as it seems.

@shivshankar11
Copy link

There's nothing stopping you from installing pre-built wheels from the link above. Download the Python 3.10 version, open the Python Packages dialog, click the + button, and enter the path to the file you downloaded:

Image

Congrats, Triton is now installed in whichever webUI you chose.

Q: Is there any roadmap on updated/compatible Python version?

We are working on it. It's not as easy as it seems.

ITS INSTALL BUT NOT WORK, NOT A ISSUE WITH NORMAL VENV

PS S:\Ai\Visual\StabilityMatrix\Data\Packages\ComfyUI WebUI> venv\Scripts\activate
(venv) PS S:\Ai\Visual\StabilityMatrix\Data\Packages\ComfyUI WebUI> pip install triton-3.2.0-cp310-cp310-win_amd64.whl
Processing s:\ai\visual\stabilitymatrix\data\packages\comfyui webui\triton-3.2.0-cp310-cp310-win_amd64.whl
Installing collected packages: triton
Attempting uninstall: triton
Found existing installation: triton 3.1.0
Uninstalling triton-3.1.0:
Successfully uninstalled triton-3.1.0
Successfully installed triton-3.2.0
(venv) PS S:\Ai\Visual\StabilityMatrix\Data\Packages\ComfyUI WebUI> ./test.py
(venv) PS S:\Ai\Visual\StabilityMatrix\Data\Packages\ComfyUI WebUI> python test.py
Traceback (most recent call last):
File "S:\Ai\Visual\StabilityMatrix\Data\Packages\ComfyUI WebUI\test.py", line 2, in
import triton
File "S:\Ai\Visual\StabilityMatrix\Data\Packages\ComfyUI WebUI\venv\lib\site-packages\triton_init_.py", line 20, in
from .runtime import (
File "S:\Ai\Visual\StabilityMatrix\Data\Packages\ComfyUI WebUI\venv\lib\site-packages\triton\runtime_init_.py", line 1, in
from .autotuner import (Autotuner, Config, Heuristics, autotune, heuristics)
File "S:\Ai\Visual\StabilityMatrix\Data\Packages\ComfyUI WebUI\venv\lib\site-packages\triton\runtime\autotuner.py", line 9, in
from .jit import KernelInterface
File "S:\Ai\Visual\StabilityMatrix\Data\Packages\ComfyUI WebUI\venv\lib\site-packages\triton\runtime\jit.py", line 12, in
from ..runtime.driver import driver
File "S:\Ai\Visual\StabilityMatrix\Data\Packages\ComfyUI WebUI\venv\lib\site-packages\triton\runtime\driver.py", line 1, in
from ..backends import backends
File "S:\Ai\Visual\StabilityMatrix\Data\Packages\ComfyUI WebUI\venv\lib\site-packages\triton\backends_init_.py", line 50, in
backends = discover_backends()
File "S:\Ai\Visual\StabilityMatrix\Data\Packages\ComfyUI WebUI\venv\lib\site-packages\triton\backends_init
.py", line 44, in _discover_backends
driver = load_module(name, os.path.join(root, name, 'driver.py'))
File "S:\Ai\Visual\StabilityMatrix\Data\Packages\ComfyUI WebUI\venv\lib\site-packages\triton\backends_init
.py", line 12, in _load_module
spec.loader.exec_module(module)
File "S:\Ai\Visual\StabilityMatrix\Data\Packages\ComfyUI WebUI\venv\lib\site-packages\triton\backends\amd\driver.py", line 7, in
from triton.runtime.build import build
File "S:\Ai\Visual\StabilityMatrix\Data\Packages\ComfyUI WebUI\venv\lib\site-packages\triton\runtime\build.py", line 8, in
import setuptools
File "S:\Ai\Visual\StabilityMatrix\Data\Packages\ComfyUI WebUI\venv\lib\site-packages\setuptools_init
.py", line 22, in
import distutils_hack.override # noqa: F401
File "S:\Ai\Visual\StabilityMatrix\Data\Packages\ComfyUI WebUI\venv\lib\site-packages_distutils_hack\override.py", line 1, in
import('distutils_hack').do_override()
File "S:\Ai\Visual\StabilityMatrix\Data\Packages\ComfyUI WebUI\venv\lib\site-packages_distutils_hack_init
.py", line 89, in do_override
ensure_local_distutils()
File "S:\Ai\Visual\StabilityMatrix\Data\Packages\ComfyUI WebUI\venv\lib\site-packages_distutils_hack_init
.py", line 76, in ensure_local_distutils
assert '_distutils' in core.file, core.file
AssertionError: S:\Ai\Visual\StabilityMatrix\Data\Packages\ComfyUI WebUI\venv\Scripts\python310.zip\distutils\core.pyc

@mohnjiles
Copy link
Contributor

There's nothing stopping you from installing pre-built wheels from the link above. Download the Python 3.10 version, open the Python Packages dialog, click the + button, and enter the path to the file you downloaded:
Image
Congrats, Triton is now installed in whichever webUI you chose.

Q: Is there any roadmap on updated/compatible Python version?

We are working on it. It's not as easy as it seems.

ITS INSTALL BUT NOT WORK, NOT A ISSUE WITH NORMAL VENV

PS S:\Ai\Visual\StabilityMatrix\Data\Packages\ComfyUI WebUI> venv\Scripts\activate (venv) PS S:\Ai\Visual\StabilityMatrix\Data\Packages\ComfyUI WebUI> pip install triton-3.2.0-cp310-cp310-win_amd64.whl Processing s:\ai\visual\stabilitymatrix\data\packages\comfyui webui\triton-3.2.0-cp310-cp310-win_amd64.whl Installing collected packages: triton Attempting uninstall: triton Found existing installation: triton 3.1.0 Uninstalling triton-3.1.0: Successfully uninstalled triton-3.1.0 Successfully installed triton-3.2.0 (venv) PS S:\Ai\Visual\StabilityMatrix\Data\Packages\ComfyUI WebUI> ./test.py (venv) PS S:\Ai\Visual\StabilityMatrix\Data\Packages\ComfyUI WebUI> python test.py Traceback (most recent call last): File "S:\Ai\Visual\StabilityMatrix\Data\Packages\ComfyUI WebUI\test.py", line 2, in import triton File "S:\Ai\Visual\StabilityMatrix\Data\Packages\ComfyUI WebUI\venv\lib\site-packages\triton__init__.py", line 20, in from .runtime import ( File "S:\Ai\Visual\StabilityMatrix\Data\Packages\ComfyUI WebUI\venv\lib\site-packages\triton\runtime__init__.py", line 1, in from .autotuner import (Autotuner, Config, Heuristics, autotune, heuristics) File "S:\Ai\Visual\StabilityMatrix\Data\Packages\ComfyUI WebUI\venv\lib\site-packages\triton\runtime\autotuner.py", line 9, in from .jit import KernelInterface File "S:\Ai\Visual\StabilityMatrix\Data\Packages\ComfyUI WebUI\venv\lib\site-packages\triton\runtime\jit.py", line 12, in from ..runtime.driver import driver File "S:\Ai\Visual\StabilityMatrix\Data\Packages\ComfyUI WebUI\venv\lib\site-packages\triton\runtime\driver.py", line 1, in from ..backends import backends File "S:\Ai\Visual\StabilityMatrix\Data\Packages\ComfyUI WebUI\venv\lib\site-packages\triton\backends__init__.py", line 50, in backends = discover_backends() File "S:\Ai\Visual\StabilityMatrix\Data\Packages\ComfyUI WebUI\venv\lib\site-packages\triton\backends__init_.py", line 44, in discover_backends driver = load_module(name, os.path.join(root, name, 'driver.py')) File "S:\Ai\Visual\StabilityMatrix\Data\Packages\ComfyUI WebUI\venv\lib\site-packages\triton\backends__init.py", line 12, in load_module spec.loader.exec_module(module) File "S:\Ai\Visual\StabilityMatrix\Data\Packages\ComfyUI WebUI\venv\lib\site-packages\triton\backends\amd\driver.py", line 7, in from triton.runtime.build import build File "S:\Ai\Visual\StabilityMatrix\Data\Packages\ComfyUI WebUI\venv\lib\site-packages\triton\runtime\build.py", line 8, in import setuptools File "S:\Ai\Visual\StabilityMatrix\Data\Packages\ComfyUI WebUI\venv\lib\site-packages\setuptools__init.py", line 22, in import distutils_hack.override # noqa: F401 File "S:\Ai\Visual\StabilityMatrix\Data\Packages\ComfyUI WebUI\venv\lib\site-packages_distutils_hack\override.py", line 1, in import('distutils_hack').do_override() File "S:\Ai\Visual\StabilityMatrix\Data\Packages\ComfyUI WebUI\venv\lib\site-packages_distutils_hack__init.py", line 89, in do_override ensure_local_distutils() File "S:\Ai\Visual\StabilityMatrix\Data\Packages\ComfyUI WebUI\venv\lib\site-packages_distutils_hack__init__.py", line 76, in ensure_local_distutils assert '_distutils' in core.file, core.file AssertionError: S:\Ai\Visual\StabilityMatrix\Data\Packages\ComfyUI WebUI\venv\Scripts\python310.zip\distutils\core.pyc

There's no need to yell. If you want it done, the code is open source, feel free to submit a PR.

@Talae06
Copy link

Talae06 commented Mar 11, 2025

I've been using StabilityMatrix for a long time, but I guess the only way to have Triton actually working is to drop it and switch to ComfyUI portable, then ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants