Build fails with rustc 1.80.1

[jonathan-conder]

Describe the bug

error[E0282]: type annotations needed
   --> src/ui.rs:388:26
    |
388 |                         .collect::<Box<_>>()
    |                          ^^^^^^^ cannot infer type of the type parameter `B` declared on the method `collect`
389 |                         .join(" ")
    |                          ---- type must be known at this point
    |
help: consider specifying the generic argument
    |
388 |                         .collect::<Vec<_>>()
    |                                 ~~~~~~~~~~

For more information about this error, try `rustc --explain E0282`.
error: could not compile `nvim-gtk` (bin "nvim-gtk") due to 1 previous error

Seems to be related to rust-lang/rust#127343

Possible fix:

diff -ru a/src/ui.rs b/src/ui.rs
--- a/src/ui.rs
+++ b/src/ui.rs
@@ -385,7 +386,7 @@
                     files_list
                         .iter()
                         .map(|f| misc::escape_filename(f))
-                        .collect::<Box<_>>()
+                        .collect::<Box<[_]>>()
                         .join(" ")
                 ));
             } else {

Technical information (please complete the following information):

• OS: NixOS unstable
• Neovim version: 0.10.1
• Neovim-Gtk build version: 1.0.4

[Lyude]

Hi - this fix looks fine to me, would you mind filing an MR?

[Lyude]

...also - I had no idea distros had actually started packaging this - I'm going to actually put something on my schedule to check github more often then :). Sorry about the delay!

[jonathan-conder]

It looks like this is already fixed on the main branch, so if anything this is more of a request to make a new release

[jonathan-conder]

There's no rush though, I already added this patch to the nix package. But would be nice to be able to remove that at some point.