-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Telescope extension being incorrectly drawn #5
Comments
Note that not only it draws wrong but when dismissing it, some gargage is still left in the screen (the part that was outside the "modal") |
Hm, I wonder if daa84#263 might be relevant here. Either way, will try to get to this issue when I have the time :) |
I actually have that merged into my fork of yours as well, I can submit that PR too. |
I can reproduce this issue with Inconsolata font (and I can't reproduce this using Fira Code font), and confirm that the commits handling CJK can fix the Telescope UI in neovim-gtk. |
Basically Yao Wei's idea from #7, but use start using grapheme clusters instead of character indices in order to avoid breaking languages such as Hindi. Fixes #5 Co-authored-by: Yao Wei (魏銘廷) <[email protected]>
Basically Yao Wei's idea from #7, but start using grapheme clusters instead of character indices in order to avoid breaking languages such as Hindi. Fixes #5 Co-authored-by: Yao Wei (魏銘廷) <[email protected]>
@bellini666 @medicalwei OK - I ended up going with Yao Wei's itemizer changes, but modified them to use grapheme clusters which looks like it fixes CJK and languages like Hindi for me locally. Could you guys try b9b2201 and let me know if it still works for y'all? |
Hey @Lyude . Just tested it here and it fixes the issue :) |
Cool! I'm going to go ahead and merge me and @medicalwei 's fixes then |
Describe the bug
I was trying to use the telescope extension and it works fine on terminal, but it is totally incorrectly drawn on neovim-gtk:
Based on the fact that it only happens on GUI and not the terminal, I don't think the problem is with telescope itself, but I might be wrong. So either way I'm posting it here...
Technical information (please complete the following information):
Linux (Debian Testing/Unstable up to date)
Neovim 0.5.1
4e466e3
The text was updated successfully, but these errors were encountered: