Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telescope extension being incorrectly drawn #5

Closed
bellini666 opened this issue Oct 17, 2021 · 7 comments
Closed

Telescope extension being incorrectly drawn #5

bellini666 opened this issue Oct 17, 2021 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@bellini666
Copy link

Describe the bug

I was trying to use the telescope extension and it works fine on terminal, but it is totally incorrectly drawn on neovim-gtk:

Screenshot from 2021-10-17 10-15-55

Based on the fact that it only happens on GUI and not the terminal, I don't think the problem is with telescope itself, but I might be wrong. So either way I'm posting it here...

Technical information (please complete the following information):

  • OS: [e.g. Windows, Linux Ubuntu]

Linux (Debian Testing/Unstable up to date)

  • Neovim version: [e.g. .0.0.3]

Neovim 0.5.1

  • Neovim-Gtk build version: [e.g. flatpak, commit hash]

4e466e3

@bellini666
Copy link
Author

Note that not only it draws wrong but when dismissing it, some gargage is still left in the screen (the part that was outside the "modal")

@Lyude
Copy link
Owner

Lyude commented Oct 19, 2021

Hm, I wonder if daa84#263 might be relevant here. Either way, will try to get to this issue when I have the time :)

@jacobmischka
Copy link

I actually have that merged into my fork of yours as well, I can submit that PR too.

@medicalwei
Copy link

I can reproduce this issue with Inconsolata font (and I can't reproduce this using Fira Code font), and confirm that the commits handling CJK can fix the Telescope UI in neovim-gtk.

@Lyude Lyude added the bug Something isn't working label Oct 23, 2021
@Lyude Lyude self-assigned this Oct 31, 2021
Lyude added a commit that referenced this issue Oct 31, 2021
Basically Yao Wei's idea from #7, but use start using grapheme clusters
instead of character indices in order to avoid breaking languages such as
Hindi.

Fixes #5

Co-authored-by: Yao Wei (魏銘廷) <[email protected]>
Lyude added a commit that referenced this issue Oct 31, 2021
Basically Yao Wei's idea from #7, but start using grapheme clusters instead
of character indices in order to avoid breaking languages such as Hindi.

Fixes #5

Co-authored-by: Yao Wei (魏銘廷) <[email protected]>
@Lyude
Copy link
Owner

Lyude commented Oct 31, 2021

@bellini666 @medicalwei OK - I ended up going with Yao Wei's itemizer changes, but modified them to use grapheme clusters which looks like it fixes CJK and languages like Hindi for me locally. Could you guys try b9b2201 and let me know if it still works for y'all?

@bellini666
Copy link
Author

Hey @Lyude . Just tested it here and it fixes the issue :)

@Lyude
Copy link
Owner

Lyude commented Nov 1, 2021

Hey @Lyude . Just tested it here and it fixes the issue :)

Cool! I'm going to go ahead and merge me and @medicalwei 's fixes then

@Lyude Lyude closed this as completed in 5938c49 Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants