Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve verbosity #9

Open
develop-cs opened this issue Apr 5, 2024 · 0 comments
Open

Improve verbosity #9

develop-cs opened this issue Apr 5, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@develop-cs
Copy link
Collaborator

Is your feature request related to a problem? Please describe

The current verbose mode contains information about "Why rule ABC was activated?". However, we often need information about "Why rule ABC was NOT activated?".

Describe the solution you'd like

Upgrade the verbosity data.

Before :

{
      "verbosity": {
          "rule_set": "second_rule_set",
          "results": [
              {
                  "rule_group": "admission",
                  "verified_conditions": {
                      "condition": {
                          "expression": "HAS_SCHOOL_AUTHORIZED_POWER",
                          "values": {"HAS_SCHOOL_AUTHORIZED_POWER": True},
                      },
                  },
                  "activated_rule": "ADM_OK",
                  "action_result": {"admission": True},
              },
      },
}

After ➡️ unverified_conditions key :

{
        "verbosity": {
            "rule_set": "second_rule_set",
            "results": [
                {
                    "rule_group": "admission",
                    "unverified_conditions": {
                        "condition": {
                            "expression": "HAS_SCHOOL_AUTHORIZED_POWER and HAS_CUSTOM_POWER",
                            "values": {"HAS_SCHOOL_AUTHORIZED_POWER": True, "HAS_CUSTOM_POWER": False},
                        },
                    "verified_conditions": {
                        "condition": {
                            "expression": "HAS_SCHOOL_AUTHORIZED_POWER",
                            "values": {"HAS_SCHOOL_AUTHORIZED_POWER": True},
                        },
                    },
                    "activated_rule": "ADM_OK",
                    "action_result": {"admission": True},
                },
        },
}
@develop-cs develop-cs added the enhancement New feature or request label Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant