Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🥅 améliorer un message de raise + minor updates dans la doc (contributing.md ..) #187

Open
VandvC opened this issue Dec 9, 2024 · 1 comment

Comments

@VandvC
Copy link

VandvC commented Dec 9, 2024

Description of Problem:

raise TypeError(f"Object {obj_class} does not inherit from the SaverMixin class") # pragma: no cover

melusine/pipeline.py:224: 
raise TypeError(f"Object {obj_class} does not inherit from the SaverMixin class")  # pragma: no cover 

reference à SaverMixin alors que la classe n'est pas définie.

Overview of the Solution
Remplacer par IoMixin et faire quelques updates dans la doc (lien mort)

Definition of Done
Documentation et correction du message de raise

@HugoPerrier
Copy link
Contributor

Je propose de modifier la condition sur l'héritage IoMixin (issubclass) par une condition sur la présence d'une méthode from_config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants