Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ build errors with some intel compilers #2

Open
matthewhoffman opened this issue Jun 3, 2021 · 0 comments
Open

C++ build errors with some intel compilers #2

matthewhoffman opened this issue Jun 3, 2021 · 0 comments

Comments

@matthewhoffman
Copy link

From @xylar:
I'm seeing build errors when I try to build MALI (without Albany) on Compy with intel and impi (the compass default settings from MPAS-Dev/compass#126):
In file included from Interface_velocity_solver.cpp(19):

Interface_velocity_solver.hpp(189): error: space required between adjacent ">" delimiters of nested template argument lists (">>" is the right shift operator)
      const std::vector<std::vector<int>> procsSharingVertices,
                                       ^
Interface_velocity_solver.cpp(296): error: identifier "nullptr" is undefined
    if (bodyForce_F!=nullptr) {
                     ^
Interface_velocity_solver.cpp(758): error: space required between adjacent ">" delimiters of nested template argument lists (">>" is the right shift operator)
    std::vector<std::vector<int>> procsSharingVertices(nVertices);
                               ^
Interface_velocity_solver.cpp(1638): error: no suitable conversion function from "std::basic_string<char, std::char_traits<char>, std::allocator<char>>" to "const char *" exists
      outfile.open (name.str(), std::ios::out | std::ios::trunc);
                    ^
Interface_velocity_solver.cpp(1659): error: namespace "std" has no member "is_sorted"
         if(!std::is_sorted(indexToVertexID.begin(), indexToVertexID.end())) {
                  ^
Interface_velocity_solver.cpp(1840): warning #3496: lambda expressions are a C++11 feature
      std::sort(sortingIndices.begin(), sortingIndices.end(), [&](int il, int ir) {
                                                              ^
Interface_velocity_solver.cpp(1840): error: a template argument may not reference a local type
      std::sort(sortingIndices.begin(), sortingIndices.end(), [&](int il, int ir) {
      ^

I was able to build on Compy by adding -std=c++11 to the CXXFLAGS_OPT :
CXXFLAGS_OPT = -O3 -std=c++11

trhille pushed a commit to trhille/E3SM that referenced this issue Jun 25, 2021
Fix energy leak from GW, fix number 2

Another GW energy fix: fixed indexing bug in
momentum_energy_conservation(), which is active for convective
 and frontal parts. Applied the same idea to the orographic part
 (this is controlled by use_gw_energy_fix, on by default).

[non-BFB] because of the bug in one of GW routines.

* oksanaguba/eam/gw-energy-fix2:
  fix in case ttgw is not zero
  renaming variable, adding to namelist
  add comments
  fix MALI-Dev#2
alexolinhager added a commit that referenced this issue May 22, 2024
Addresses minor cleaning edits following second round of review
matthewhoffman pushed a commit that referenced this issue Oct 28, 2024
matthewhoffman pushed a commit that referenced this issue Oct 28, 2024
trhille pushed a commit to trhille/E3SM that referenced this issue Nov 21, 2024
…erf/dry-dep

Implement the MAMDryDep::run_impl() function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant