Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mass budget accounting requires new calculations and modifications #23

Open
matthewhoffman opened this issue Mar 3, 2022 · 3 comments
Labels

Comments

@matthewhoffman
Copy link

Currently it is not possible to close the mass budget for grounded or floating ice. It is possible to get close with extensive post-processing calculations, but this accounting should happen online and be a standard output from all runs that closes BFB.

Some known issues are:

  • GL mask isn’t really GL mask
  • subglacial lakes need to be excluded from ice shelf
  • non-dynamic floating fringe should be part of grounded mask
  • GtoF migrations flux is necessary to close budget and GLflux needs to make use of appropriate GL position when the GL moves
  • calculations may need to occur online to capture changes to mask during the timestep
  • possibly we need special masks for budgets

cc: @trhille

@trhille
Copy link

trhille commented Mar 3, 2022

Using https://github.com/trhille/Humboldt-scripts/blob/debug_budgets/recalculate_GL_flux_with_edgeVelocities.py at commit trhille/Humboldt-scripts@845637c we are able to get reasonable results for plotting, but fractional differences early in the run are still too high. Here the bottom panel compares the magenta and dashed blue curves in the top panel.

image

@trhille
Copy link

trhille commented May 12, 2022

* GL mask isn’t really GL mask

Addressed in PR #37

@trhille
Copy link

trhille commented Jan 4, 2023

  • subglacial lakes need to be excluded from ice shelf

Adressed in PR #54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants