-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add active & reactive load as measurements #2
Comments
With regards to the cases mention in here, which are repeated here for ease: Also, let us define a measurement as the true value+noise in contrast to the pure (clean) true value.
I agree that this should be explained in a README file in detail. Also, an error should raised when the user enters a a power demand measurement at a generator bus in the Finally, do you suggest creating a new PR for the above modifications only? |
I just mean that the measurement for the generator at the same bus is not provided. I view cases (c) and (d) as essentially equivalent. Both are cases where there are multiple injections at the bus, but we are not provided with measurement data for all of them.
Did you mean cases (c), (d), and (e)?
Yes. Let's create a new PR that does the following ...
Note, the second item does change the behavior of the existing code and examples for buses that have both load and generation, with a measurement provided for the generation. The assumption in the original code is that the load is a known quantity. It seems to me that for consistency we must assume that a quantity is either provided as a measurement, or we do not have any information about its value. |
In #1, @aldalahmeh adds the option to include active and reactive load as measurements, along with other changes/new features. We are splitting this into separate threads to more easily track the discussion.
So, this proposed change is fine for loads at buses without generators. But, for loads at generator buses, this is not consistent with the assumption in the existing code, which assumes the load is a known quantity. To handle that case, we need more discussion and design work.
I'm ok with moving ahead with simply adding load measurements as in #1 if we also include a README that clearly documents that load measurements assume zero generation at the bus, and generator measurements assume known (possibly 0) load at the bus, and no multiple generators per bus. In fact, it should throw an error in the case of multiple injections (load and gen, or multiple gens) at a bus, until we can implement a more rational way of handling those cases.
If and when we decide to attempt to go toward a more general design that handles multiple injection measurements at a bus, this comment describes the cases I think we need to handle.
What do you think @aldalahmeh?
If you are in agreement, could you create a new PR that just adds the active and reactive load measurements, throws an error for the multiple injection measurements per bus, and adds a
README.md
as described above?The text was updated successfully, but these errors were encountered: