Feature/build tree #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add functionality for building a tree representation of the nested line nubmers.
Add method for .has_children?
jhixson
previously approved these changes
Apr 11, 2024
There was a problem hiding this comment.
When I have a line representation like this:
%NestedLines{
lines: [
[1],
[0, 1],
[0, 1],
[0, 1],
[0, 1],
[0, 1],
[1],
[0, 1],
[0, 1],
[0, 1],
[0, 1],
[0, 1],
[0, 0, 1]
]
}The build_tree output gives me
[
%{
line: "1",
children: [
%{line: "1.1", children: []},
%{line: "1.2", children: []},
%{line: "1.3", children: []},
%{line: "1.4", children: []},
%{line: "1.5", children: []}
]
},
%{
line: "2",
children: [
%{line: "2.1", children: [%{line: "2.5.1", children: []}]},
%{line: "2.2", children: []},
%{line: "2.3", children: []},
%{line: "2.4", children: []},
%{line: "2.5", children: []}
]
}
]Should that child line be under this map instead? %{line: "2.5", children: []}
Update logic for adding child line to siblings: Push onto the front of the list instead of appending to the end. Check the proper line property on the latest tree line when looking for the parent line. Update build_tree to reverse all children, needed with change to sort of child lines. Add tests.
|
Adjusted logic for adding lines to the proper parent and added more tests. |
Use indentation for the first line
Update usage documentation to include a blurb about build_tree. Update documentation to use line numbers instead of internal lines representation
Change .build_tree to .tree
|
Looks awesome! I like that the tree representation is explicit 👍. 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
build_treeandhas_children?to NestedLines