Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling mods paints them one by one #2

Open
MCW77 opened this issue May 9, 2022 · 2 comments
Open

Scrolling mods paints them one by one #2

MCW77 opened this issue May 9, 2022 · 2 comments

Comments

@MCW77
Copy link
Owner

MCW77 commented May 9, 2022

Description:

Scrolling mods in the explorer paints the mods one by one when they enter the view.

Current implemementation of RenderIfVisible creates an intersection observer for every wrapped ModDetail.
By adding the feature of using a shared observer to RenderIfVisible we should be able to handle several mods that intersect the root at once.

Steps to reproduce the issue:

  • Go to the mod explorer
  • Scroll the mods fast enough so that a bunch get into view at the same time
  • Observe how each mod that scrolled into view is painted one after the other

Expected behavior:

All mods getting into view start painting at the same time

Actual behavior:

Mods scrolling into view paint one after the other

@pawee
Checkout my fork of the optimizer. By virtualizing the mods entering the mod explorer is instant, also filtering mods.
Once i resolve the two issues i currently have with the intersection observer, the scrolling should be fast too.
You can test my fork at mods-manager.pages.dev

@pawee
Copy link

pawee commented May 12, 2022

I'm trying to check this out but I can't find the fetch data button when opening in mobile browser.

@MCW77
Copy link
Owner Author

MCW77 commented May 12, 2022

You don't need it for the first fetch and it will be there after you entered your allycode and thus triggered the first fetch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants