Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update transformations library #1717

Open
kain88-de opened this issue Nov 24, 2017 · 5 comments
Open

update transformations library #1717

kain88-de opened this issue Nov 24, 2017 · 5 comments

Comments

@kain88-de
Copy link
Member

https://www.lfd.uci.edu/~gohlke/code/transformations.py.html

There is a 2017 version of the library. Should we update it? I have also recently written the author about an odd behavior of the function quaternion_matrix which seems to return the matrix for the transpose quaternion.

@richardjgowers
Copy link
Member

#401 is related here.

I've never really been happy how we've included transformations, but it doesn't look like it's packaged up on pypi or conda. Is there a reason to "upgrade"? (if it isn't broke, don't fix it?)

@kain88-de
Copy link
Member Author

I have to do a diff. It definitely looks different to our version though. The docs need definitely an update though. Some of the return values are surprising for example quaternion_matrix returns the transpose of the definition used in the reference given in transformations about quaternion matrix conversion.

@orbeckst
Copy link
Member

The proper way to do it would be a separate transformations package with its own tests. If Christoph Gohlke does not want to do this we could consider a fork in our repo and start maintaining it by pulling our tests into the separate lib.

@orbeckst
Copy link
Member

orbeckst commented Dec 12, 2017

A few people have created transformation packages but maintenance appears to be non-existent:

This one is maintained:

... but I don't think it includes the C versions of the transformations module.

@orbeckst orbeckst added the PBC label Jan 24, 2018
@orbeckst
Copy link
Member

There's a pip package https://pypi.org/project/transformations/ with a version 2021.6.6 and recent history:

  • 2021.6.6 Remove support for Python 3.6 (NEP 29).
  • 2020.1.1 Remove support for Python 2.7 and 3.5.
  • 2019.4.22 Fix setup requirements.

However, it appears to be in deprecation mode:

Transformations.py is no longer actively developed and has a few known issues and numerical instabilities. The module is mostly superseded by other modules for 3D transformations and quaternions:

If we could remove our version and use an externally maintained one then that would be good.

We would still have to have at least shims in place until 3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants