-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update transformations library #1717
Comments
#401 is related here. I've never really been happy how we've included transformations, but it doesn't look like it's packaged up on pypi or conda. Is there a reason to "upgrade"? (if it isn't broke, don't fix it?) |
I have to do a diff. It definitely looks different to our version though. The docs need definitely an update though. Some of the return values are surprising for example |
The proper way to do it would be a separate transformations package with its own tests. If Christoph Gohlke does not want to do this we could consider a fork in our repo and start maintaining it by pulling our tests into the separate lib. |
A few people have created
This one is maintained:
... but I don't think it includes the C versions of the |
There's a pip package https://pypi.org/project/transformations/ with a version 2021.6.6 and recent history:
However, it appears to be in deprecation mode:
If we could remove our version and use an externally maintained one then that would be good. We would still have to have at least shims in place until 3.0. |
https://www.lfd.uci.edu/~gohlke/code/transformations.py.html
There is a 2017 version of the library. Should we update it? I have also recently written the author about an odd behavior of the function
quaternion_matrix
which seems to return the matrix for the transpose quaternion.The text was updated successfully, but these errors were encountered: