Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source file locations #444

Closed
kain88-de opened this issue Sep 23, 2015 · 7 comments
Closed

Source file locations #444

kain88-de opened this issue Sep 23, 2015 · 7 comments
Assignees
Milestone

Comments

@kain88-de
Copy link
Member

Place all source files for compiled shared object files into the same folder as the final shared object file.

*.pyx files and cython-generated *.c would be in the same directory as the *.so. While external dependend C/C++/Fortran libraries are in dedicate src and include folders. See the following tree as an example.

MDAnalysis 
      |--lib
      |   |-- _distances.so
      |   |-- distances.pyx
      |   |-- distances.c
      |-- coordinates
          |-- _dcdmodule.so
          |-- src
              |-- dcd.c
          |-- include
              |-- dcd.h

This is standard see numpy, scipy, scikit-learn. mdtraj

@orbeckst
Copy link
Member

Why not? If it makes clearer what belongs together I have no objections.

@orbeckst orbeckst added this to the 1.0 milestone Sep 27, 2015
@orbeckst orbeckst mentioned this issue Sep 27, 2015
11 tasks
@orbeckst
Copy link
Member

I am officially in favor of the proposal. Any other voices?

@hainm
Copy link
Contributor

hainm commented Sep 27, 2015

I always favor following common concept in ecosystem. so +1.

@kain88-de
Copy link
Member Author

could we maybe add an easy tag to this?

@orbeckst
Copy link
Member

orbeckst commented Oct 1, 2015

Something like the 'repository' tag that I just added (basically, anything relating to how we organize code), or do you want something more specific?

@kain88-de
Copy link
Member Author

I thought about an easy tag meaning they are bugs easy to solve. It would be a mark to show people who want to contribute what good bugs to pick are at the beginning.

@orbeckst
Copy link
Member

orbeckst commented Oct 1, 2015

Ok, I added tag Difficulty-easy and tag Difficulty-hard to the list; obviously, that lies somewhat in the eye of the beholder but please: tag away!

(I purposefully omitted Difficulty-medium to avoid swamping issues with a default tag...)

@richardjgowers richardjgowers self-assigned this Oct 2, 2015
richardjgowers added a commit that referenced this issue Oct 2, 2015
Moved source for coordinates.dcd, lib.distances, lib.transformations,
lib.pyqcprot and coordinates.libxdrfile.

Removed deprecated src files

Updated c files for Cython
richardjgowers added a commit that referenced this issue Oct 2, 2015
Moved many extensions files alongside the python code (Issue #444)
@orbeckst orbeckst mentioned this issue Oct 6, 2015
lohani2280 pushed a commit to lohani2280/mdanalysis that referenced this issue Feb 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants