Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make waterdynamics stop behaviour the same as AnalysisBase #22

Open
IAlibay opened this issue Jun 8, 2020 · 2 comments
Open

Make waterdynamics stop behaviour the same as AnalysisBase #22

IAlibay opened this issue Jun 8, 2020 · 2 comments

Comments

@IAlibay
Copy link
Member

IAlibay commented Jun 8, 2020

Is your feature request related to a problem?

As detailed in MDAnalysis/mdanalysis#2525 (comment) several waterdynamics methods currently have an inclusive tf (i.e. final frame) behaviour instead of the exclusive behaviour exhibited by AnalysisBase's stop. In order to offer users a consistent API, it would be advantageous to make everything exclusive.

Describe the solution you'd like

Change the behaviour of the final frame definitions in waterdynamics to be exclusive.

Describe alternatives you've considered

The ideal alternative here is to switch waterdynamics over to AnalysisBase.

Additional context

PR MDAnalysis/mdanalysis#2525

@PicoCentauri
Copy link

I'm already working on the Analysis modules. I will move them to AnalysisBase.

@hmacdope
Copy link
Member

Im going to add this to 3.0 as fits in thematically with MDAnalysis/mdanalysis#3893

@IAlibay IAlibay transferred this issue from MDAnalysis/mdanalysis Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants