Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for native-to-standard space transforms #11

Open
tsalo opened this issue Nov 7, 2020 · 8 comments
Open

Drop support for native-to-standard space transforms #11

tsalo opened this issue Nov 7, 2020 · 8 comments

Comments

@tsalo
Copy link
Member

tsalo commented Nov 7, 2020

Summary

This stems from Brainhack-Donostia/ica-aroma-org#41 (comment). We will drop support for native-to-standard space transforms for now, and all native-space data must be accompanied with tissue probability maps for now.

Next Steps

  1. Remove all transforms.
  2. Drop FEAT directory support too, maybe?
@tsalo
Copy link
Member Author

tsalo commented Nov 8, 2020

I think the key problem here is that nitransforms doesn't support nonlinear warps. Or at least I can't find any information on warps in their documentation.

@CesarCaballeroGaudes
Copy link

Can we ask @oesteban?

@oesteban
Copy link

oesteban commented Nov 9, 2020

I think the key problem here is that nitransforms doesn't support nonlinear warps. Or at least I can't find any information on warps in their documentation.

Nonlinear warps from FSL?

  • ANTs/ITK displacements fields are supported (some minor tweaks loading some kinds of h5 files might be necessary, but everything is doable ATM).
  • FSL will require taking ENH: I/O of FSL displacements fields nipy/nitransforms#51 to the endline (mini-BHD project?)
  • AFNI is not yet supported, although considering the consistency of their implementation I don't think it will be difficult once we pin down ANTs and FSL.

@tsalo
Copy link
Member Author

tsalo commented Nov 9, 2020

@oesteban I think FSL is the most likely source of transforms (since ICA-AROMA is designed for FSL-processed data), but we are hoping to support data coming from anywhere. It doesn't sound like that's possible yet, though.

We could try to support FSL if and when nipy/nitransforms#51 is merged, though, and add support for each package as it is incorporated.

@oesteban
Copy link

@oesteban I think FSL is the most likely source of transforms (since ICA-AROMA is designed for FSL-processed data), but we are hoping to support data coming from anywhere. It doesn't sound like that's possible yet, though.

Not for fMRIPrep - I know this is not the only pipeline capable of running ICA-AROMA but probably the best test-bed for a standalone implementation of AROMA.

For the time being, c3d converts FSL distortion maps into ITK's.

@eurunuela eurunuela transferred this issue from Brainhack-Donostia/ica-aroma-org Nov 10, 2020
@eurunuela
Copy link
Collaborator

Okay, so shall we drop all these dependencies and use probability maps until poldracklab/nitransforms#51 is merged?

@oesteban
Copy link

I think that was @tsalo's original proposal - do not bother at this point about how the TPMs are generated in the native space, just assume they are defined there.

@eurunuela
Copy link
Collaborator

I think that was @tsalo's original proposal - do not bother at this point about how the TPMs are generated in the native space, just assume they are defined there.

Yes. I wanted to make sure. I was starting to get lost in the conversation having now two different repos after the Brainhack Donostia tutorial 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

4 participants