Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tutorial, clean code etc. #3

Open
phiwei opened this issue Jun 3, 2019 · 1 comment
Open

tutorial, clean code etc. #3

phiwei opened this issue Jun 3, 2019 · 1 comment

Comments

@phiwei
Copy link

phiwei commented Jun 3, 2019

Hi,

thank you for the implementation, I will maybe test it in my project. While your paper shows interesting results regarding speed-up, you describe the code as "usable right out of the box". This is not true with the current documentation and code structure.

I would suggest:

  • add a requirements file
  • add proper usage examples for different cases, with example links to where to download example images
  • improve documentation (comment the functions, both with a header per function as well as within the code)

Otherwise, the quality of the code invokes no confidence in the quality of its results.
Best wishes

@deepakanandece
Copy link
Contributor

I will put a tutorial regarding usage. It is in "main.py" you can find all the options. The variable name is intitutive. I agree more comments are required. Requirements are openslide, tensorflow, cv2 and other basic package. I will update the repo within a week. For sample images these are frely available on tcga website. However hosting digital pathology images is not allowed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants