lower jina rate floor #647
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
first test, with min_T9 = 1d-4 (1d5 K)
Debraheem
added
release-blocker
|
i will test after the current test suite run finishes. |
Debraheem
removed
the
release-blocker
pmocz
reviewed
Sep 6, 2024
rates/private/rates_support.f90
Outdated
| ! like rni56ec_to_co56,rco56ec_to_fe56 | ||
| !write(*, '(a,i4,2x,a)') 'Warning: non-positive value for rate in ', & | ||
| ! j, trim(reaction_Name(reaction_id(j))) | ||
| rate_logR = rattab(j, i) ! don't convert to log space. |
There was a problem hiding this comment.
I could be misunderstanding what is going on here. Are you saying the data tables (in linear space) have some -1 entries? Then setting rate_logR = -1 could be a problem, no?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #645
We currently have the default reaclib_min_T9 = 1d-2 (i.e. no reactions below 10 MK) as a MESA default, I would like to bring this down so we are not missing key reactions like li7 and be9 burning.
I have tested with reaclib_min_T9 = 1d-4 (i.e. no reactions below 1d5 K) with no issues, see https://testhub.mesastar.org/EbF%2Flower_jina_rate_floor/commits/8555db8. The testing looks good. I would appreciate any feedback or further testing from any members of the community on this.
I will modify the changelog once we come to a conclusion on this.