From a89908f038964c5fa5f0376382db0a34b7d12bcc Mon Sep 17 00:00:00 2001 From: Tom Date: Wed, 23 Aug 2023 19:59:34 +0100 Subject: [PATCH] 0.5.0r --- .Rhistory | 8 ++++---- CRAN-SUBMISSION | 6 +++--- cran-comments.md | 21 ++++++++++++++------- 3 files changed, 21 insertions(+), 14 deletions(-) diff --git a/.Rhistory b/.Rhistory index 5611668..e49023d 100644 --- a/.Rhistory +++ b/.Rhistory @@ -1,7 +1,3 @@ -} else { -return(TRUE) -} -} #' Check whether all Python packages are available #' #' Checks if each Python dependency is available. @@ -510,3 +506,7 @@ check_rhub() install.packages("V8") check_win_devel() check_win_release() +library(devtools) +check() +build() +devtools::release() diff --git a/CRAN-SUBMISSION b/CRAN-SUBMISSION index cb500af..046609a 100644 --- a/CRAN-SUBMISSION +++ b/CRAN-SUBMISSION @@ -1,3 +1,3 @@ -Version: 0.4.2 -Date: 2023-06-13 21:47:39 UTC -SHA: dbb37fc9fbd2b8967539138aa9e27ae33c270705 +Version: 0.5.0 +Date: 2023-08-22 08:44:06 UTC +SHA: 821d0e8daed9c00948656d8618e5525fbe9ec071 diff --git a/cran-comments.md b/cran-comments.md index e9e7b3d..d184a00 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -1,5 +1,10 @@ ## v0.5.0 +This is a re-submission: + +* We have fixed the broken URL +* We have amended our package start-up messages to address the previous note + In this version, we have: * Added an automatic configuration for interfacing with Python, to ease the setup for users @@ -9,6 +14,14 @@ In this version, we have: * Updated existing vignettes * Updated accompanying YAML file to work on all major operating systems (including Apple silicon hardware) +### Note on startup messages + +The previous note referred to our use of messages in `.onLoad()`, specifically that we use 'readLine' to ask users whether they would like the package to auto-configure Python requirements. All other messages were already wrapped in `packageStartupMessage`. + +The startup messages are designed to cater to both novice and experienced users. For non-power users they provide essential information without being redundant. For power users they are essentially bypassed. Moreover, this approach differentiates between interactive and non-interactive sessions, preventing sessions hanging when run on display-less servers. + +The only write-out operation is a simple 'y/n' text file, which is crucial for rMIDAS package’s functionality. + ## Test environments * Local OS X install, R 4.3.0 * Fedora Linux, R-devel, clang, gfortran @@ -18,13 +31,7 @@ In this version, we have: ## R CMD check results -There were no errors, or warnings, and 1 note. - -The note refers to our use of messages in `.onLoad()`, specifically that we use 'readLine' to ask users whether they would like the package to auto-configure Python requirements. All other messages are wrapped in 'packageStartupMessage'. - -The startup messages are designed to cater to both novice and experienced users. For non-power users they provide essential information without being redundant. For power users they are essentially bypassed. Moreover, this approach differentiates between interactive and non-interactive sessions, preventing sessions hanging when run on display-less servers. - -The only write-out operation is a simple 'y/n' text file, which is crucial for rMIDAS package’s functionality. +There were no errors, warnings, or notes. ## Downstream dependencies There are no downstream dependencies currently.