Add NumPy 2 support #505
Add NumPy 2 support #505
Conversation
|
@tompollard you opened #506, #507, and #508 – do the changes in this PR not solve the issue? All tests pass with NumPy 2. |
| @@ -11,7 +11,7 @@ license = "MIT" | |||
|
|
|||
| [tool.poetry.dependencies] | |||
| python = ">=3.7" | |||
| numpy = ">=1.10.1,<2.0.0" | |||
| numpy = ">=2.0.0" | |||
There was a problem hiding this comment.
This could even remain numpy = ">=1.26.0", since all changes should work with both NumPy 1.x and NumPy 2.x.
|
@cbrnr thanks for looking at this and sorry for the duplicate effort.
I think the change in this pull request resolves one of the issues, but not all of them. Errors may not be obvious because (1) the test suite doesn't have full coverage and (2) overflows don't raise errors by default. I have tried to address the warnings raised when running tests with We may want to set the package to raise error on overflow when in development, which I think we can do with |
|
No problem! Feel free to take whatever you need from this PR, and let me know if you need further help. It would be great if NumPy 2 support wasn't too far in the future! |
Fixes #493.