Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging of raw tap tokens to create test set #4

Open
othomasprime opened this issue Oct 9, 2024 · 1 comment
Open

Add logging of raw tap tokens to create test set #4

othomasprime opened this issue Oct 9, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@othomasprime
Copy link
Member

To: [email protected]
Cc: Oliver Thomas [email protected]
Reply-To:
From: Oliver Thomas [email protected]
Date: Wed, 9 Oct 2024 17:18:16 +0000
I’d like to start logging the value of tmp_id as returned by the card reader. Right now we're logging it if it’s not an HID reader and if the split() causes an exception. I’m thinking we want to log it right after it is set in line 200. Maybe even log it before the lower() conversion and put that in a separate statement. My thinking is we want to collect a list of many reader output values exactly as passed. We don’t need to log associated user info so there is no security risk. The collection will be helpful for automated test cases so we can send reader values at the code at random intervals for testing, given how difficult it is to volume test otherwise.

@othomasprime othomasprime added the question Further information is requested label Oct 9, 2024
@othomasprime othomasprime self-assigned this Oct 9, 2024
@othomasprime
Copy link
Member Author

@othomasprime othomasprime added enhancement New feature or request and removed question Further information is requested labels Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant