Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StatsPerform JSON parsers: load data from memory #232

Open
denisov-vlad opened this issue Mar 18, 2022 · 0 comments
Open

StatsPerform JSON parsers: load data from memory #232

denisov-vlad opened this issue Mar 18, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@denisov-vlad
Copy link
Contributor

Current loaders is designed to read files and process them into dataframes.

It's not suitable if you want to use SDDP feed instead of SDAPI. The difference is that SDDP adds events during the match and SDAPI is available only after match.

I want to calculate some metrics during the match and created alternative memory loader based on MA3 Loader:
https://gist.github.com/denisov-vlad/28d4668c4861b7c551a6caba3c341ba2

As you see, there is a lot of duplicated code. It will be awesome to split extract functions into loading from disk and processing data.

@probberechts probberechts added the enhancement New feature or request label Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants