Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pass height information to SPADL #411

Open
znstrider opened this issue Oct 19, 2022 · 3 comments
Open

Add pass height information to SPADL #411

znstrider opened this issue Oct 19, 2022 · 3 comments
Labels
discussion enhancement New feature or request

Comments

@znstrider
Copy link
Contributor

Currently there is no information about pass height in socceraction.

I haven't checked it but I assume that the value of high passes could be significantly different from ground passes.

Do all providers offer this information and is that something that could be added to socceraction?

@probberechts
Copy link
Member

I think all providers support it to some extent:

  • Statsbomb distinguishes between ground passes, low passes (below shoulder level) and high passes.
  • Wyscout distinguishes between low ( < 1m) and high passes, but this is only defined for crosses, free kicks and long passes
  • Older Opta data has a qualifier for chipped passes. I do not have docs for more recent data.

One issue is that low / high has different meanings between providers.

I am considering adding this. Although, it has low priority. To some extent, the models should already be able to derive it from the body part used to perform the (previous) action(s) and the length of a pass.

@probberechts probberechts added the enhancement New feature or request label Oct 19, 2022
@znstrider
Copy link
Contributor Author

Agreed that the different definitions are a little problematic and there is definitely some of the info that is implicitly picked up by any model.
But in a way it will average over the expectation over both high and ground passes, which are different in a football sense and might differ in action value.

If I get around to testing a model with this information added, I'll let you know if it makes a meaningful difference.

I wonder if it makes sense to explicitly look at the difference of loss evaluations of high (& low) passes between models with/without that info additionally.

@probberechts
Copy link
Member

If I get around to testing a model with this information added, I'll let you know if it makes a meaningful difference.

That would be interesting!

I wonder if it makes sense to explicitly look at the difference of loss evaluations of high (& low) passes between models with/without that info additionally.

I would look at the Brier / AUROC scores on an independent test set + evaluate a few examples where the models give different results qualitatively.

@probberechts probberechts changed the title Missing information about pass height Add pass height information to SPADL Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants