Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pitch data can possibly overlap perfect game/no hitter text #379

Open
ty-porter opened this issue May 11, 2022 · 1 comment
Open

Pitch data can possibly overlap perfect game/no hitter text #379

ty-porter opened this issue May 11, 2022 · 1 comment
Labels
128x64 bug Something isn't working good first issue Good for newcomers

Comments

@ty-porter
Copy link
Collaborator

Pitch data is going out in 5.1.0 and needs investigation whether the default layout can cause long pitch descriptions to overlay no hitter or perfect game text

Pitch data is only enabled in default layout on 128x64 matrices

@ty-porter ty-porter added bug Something isn't working good first issue Good for newcomers 128x64 pre-release Testing new features before release labels May 11, 2022
@tracerrx
Copy link
Contributor

The simplest fix to this is to change the descriptions in data/pitches.py .. According to MLB "FT Two-Seam Fastball (synonymous with SI)" and "SI Sinker (synonymous with FT)". FWIW, I have not seen a 2 seam fastball come up yet so maybe it's deprecated?? So we could change all the DEFAULT long names to be < 13 characters:

  • 4 Seam Fastball => Fastball (or maybe 4 sm fastball)
  • 2 Seam => Sinker (or 2 sm fastball)
  • Intentional Ball => Int Ball
  • Automatic Ball => Auto Ball
  • Automatic Strike => Auto Strike

The real question is how do we patch all the fonts to get a 🔥 emoji if the pitch is > 100mph?

@ty-porter ty-porter removed the pre-release Testing new features before release label May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
128x64 bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants