Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support undeclared parameters in MLBlock #118

Open
csala opened this issue Jan 13, 2020 · 0 comments
Open

Support undeclared parameters in MLBlock #118

csala opened this issue Jan 13, 2020 · 0 comments
Assignees
@csala
Milestone
0.5.1

Comments

@csala
Copy link
Contributor

csala commented Jan 13, 2020

Current MLBlock does not support passing parameters that have not been declared in the primitive definition.
This might be necessary in cases where the arguments expected by the primitive are dynamically known at runtime, and not when the JSON annotation is created.

To fix this, a new entry called unknown should be added within the hyperparameters dictionary, which, if set to true, disables the strict checking.
@csala csala self-assigned this Jan 13, 2020
@csala csala added this to the 0.3.5 milestone Jan 13, 2020
@csala csala modified the milestones: 0.4.0, 0.4.1 Dec 22, 2020
@sarahmish sarahmish modified the milestones: 0.4.1, 0.5.0, 0.4.2 Oct 8, 2021
gsheni pushed a commit that referenced this issue Aug 29, 2022
@csala
Merge pull request #118 from bryanfarris/issue_7_add_contributing_doc…
0fb7d25 
…umentation

Add Adapters and Custom primitives docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@csala csala

Labels
None yet
Projects
None yet
Milestone
0.5.1
Development

No branches or pull requests
2 participants
@csala @sarahmish