Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Future ideas & Todo List #5

Open
MMK21Hub opened this issue Apr 7, 2022 · 28 comments
Open

Future ideas & Todo List #5

MMK21Hub opened this issue Apr 7, 2022 · 28 comments

Comments

@MMK21Hub
Copy link
Owner

MMK21Hub commented Apr 7, 2022 •
edited
Loading

  • Check Avoma's Advancement Description Capitalisation Issues spreadsheet
  • Fix missing translation string keys too?
  • https://bugs.mojang.com/browse/MC-195836 - Some subtitles are not in the correct tense/format
  • https://bugs.mojang.com/browse/MC-250062 - Several strings throughout the game contain comma splices
  • https://bugs.mojang.com/browse/MC-190146 - Game mode descriptions are grammatically incorrect/inconsistent
  • MC-250344 - Some gamerule title strings within the world creation menu are improperly capitalized
  • MC-250147 - Advancement descriptions for "Wax On" and "Wax Off" are inconsistent Marked as WAI
  • MC-250153 - Some advancement description strings are improperly capitalized (New for 22w15a!)
  • MC-250197 - Glass bottles are inconsistently referred to throughout some advancement description strings
  • MC-189261 - Various Realms buttons and texts are incorrectly capitalized
  • MC-252298 - Death messages relating to the thorns enchantment don't contain conjunctions where appropriate
  • MC-252295 - The word "whilst" within several death messages isn't spelt in American English
  • MC-252316 - The word "burnt" within some death messages isn't spelt in American English
  • MC-203095 - /xp feedback is always pluralized regardless of value output Fix implemented in 96cdc87
  • MC-256885 - The word "messages" in the `gui.chatSelection.fold string is always pluralized Fixed in vanilla 22w45a
  • Fixed in 22w16a: MC-249663 (The subtitles of some parrot imitation sounds are inconsistent with the original sounds' subtitles) and gamerule.doTraderSpawning

When any new piece of information (that affects the pack) becomes available, I will add a comment. I will strike through the comment when it's been addressed.
@MMK21Hub
Copy link
Owner Author

MMK21Hub commented Apr 8, 2022 •
edited
Loading

A comment from Avoma on Mojira:

I've been informed by a Mojang Employee not to report these issues as instead, a Google Docs Spreadsheet that I created regarding all of the capitalization errors and inconsistencies within the advancement descriptions of advancements throughout the game, has been passed on internally, so I've been reassured that there's no need to create new tickets regarding these issues.

I'm not yet sure what implications this will have for this pack. (It's also intresting that Avoma was personally contacted regarding this issue; I assume that the rest of us should carry on reporting advancement description capitalisation bugs)

@MMK21Hub
Copy link
Owner Author

MMK21Hub commented Apr 13, 2022 •
edited
Loading

In 22w15a, 33 of the 97 issues from Avoma's Advancement Description Capitalisation Issues speadsheet have been fixed.
Fixes have been removed from the pack accordingly.

@MMK21Hub
Copy link
Owner Author

MMK21Hub commented Apr 14, 2022 •
edited
Loading

New bug for 22w15a: MC-250158 (The "Sneak 100" advancement description doesn't contain a serial comma where appropriate)
Fixed in commit 011d924

@MMK21Hub
Copy link
Owner Author

https://bugs.mojang.com/browse/MC-250194 was created right as v2.4 was released :p
Since it only applies to the en_us language, I'll have to rethink my method of just copy-pasting the whole file to keep both languages up-to-date.

@MMK21Hub
Copy link
Owner Author

MMK21Hub commented Apr 14, 2022 •
edited
Loading

MC-226430 has been almost-fully fixed: https://bugs.mojang.com/browse/MC-226430?focusedCommentId=1153602&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-1153602
Superseded by #5 (comment)

@MMK21Hub
Copy link
Owner Author

MMK21Hub commented Apr 14, 2022 •
edited
Loading

MC-250143 and MC-250144 should be fixed too (Advancement description for Sneak 100 is not canonically correct)
Both were fixed in 22w18a

@MMK21Hub
Copy link
Owner Author

MMK21Hub commented Apr 19, 2022 •
edited
Loading

MC-226430 has just been marked as fixed by 22w15a:

Resolving as fixed in 22w15a. Please create a new issue if there are remaining strings that still need to be fixed.

Fix removed in commit f80b5fe

The only remaining issue with the advancements is MC-226484.
Fixed in commit c14db56

@MMK21Hub MMK21Hub changed the title Future ideas Future ideas & Todo List Apr 20, 2022
@MMK21Hub
Copy link
Owner Author

MMK21Hub commented Apr 27, 2022 •
edited
Loading

New in 22w17a: MC-250932 (Goat Horn subtitles)
Fixed in commit 97c0f8b

@MMK21Hub
Copy link
Owner Author

MMK21Hub commented May 5, 2022 •
edited
Loading

New in 22w18a: MC-251320 ("instrument.unregistered_sadface" displays raw translation string (is untranslated))

This has already been marked as Won't FIx by Mojang and the intended contents of the translation string isn't obvious, so I'll have to dig into the code to work out where exactly it's used and what its intended contents may be.

@MMK21Hub
Copy link
Owner Author

MMK21Hub commented May 18, 2022 •
edited
Loading

MC-250932 (Goat horn subtitles are improperly capitalized) and MC-249980 (The Birthday Song advancement description doesn't capitalise the word Cake) have both been fixed in 1.19-pre1
Fixed in commits bead3c9 and bab858d

@MMK21Hub
Copy link
Owner Author

MMK21Hub commented May 18, 2022 •
edited
Loading

MC-250968 (The subtitle produced when goats' horns break off doesn't contain a possessive apostrophe where appropriate and incorrectly capitalizes the word "Horn") has had its translation string changed in 1.19-pre1, so I'll need to check that our fix is still correct.
Done

@MMK21Hub
Copy link
Owner Author

MMK21Hub commented Jun 2, 2022 •
edited
Loading

New in pre-release 5: MC-252408 - Chat restriction strings consist of inconsistent concluding punctuation
Fixed in commit 142fb9d; shipped in release v2.7

@MMK21Hub
Copy link
Owner Author

MMK21Hub commented Jun 17, 2022 •
edited
Loading

Lots of issues with the new chat reporting function in 22w24a:

  • MC-253178 - The word "Non-consensual" is misspelt in the Chat Report reason picker 0b456ab (Fixed in 1.19.1-pre1)
  • MC-253182 - The second instance of a reflexive pronoun is used incorrectly in the gui.abuseReport.reason.self_harm_or_suicide.description translation string d562834
  • MC-253183 - The word "Unrelated" in the gui.chatSelection.fold translation string is unnecessarily capitalised 33b724c (Fixed in 1.19.1-pre1)
  • MC-253223 - Incorrectly-used preposition in the gui.abuseReport.reason.terrorism_or_violent_extremism.description translation string 374de01 (Fixed in 1.19.1-rc1)
  • MC-253102 - "1 Chat Messages Selected" (plural is still used when only one message is selected) 8177f8a (Fixed in 1.19.1-pre1)

Shipped in release v2.8

@MMK21Hub
Copy link
Owner Author

MMK21Hub commented Jun 30, 2022 •
edited
Loading

New bug for 1.19.1-pre2 (we're back to pre-releases 🙃)

  • MC-253741 - Inconsistent concluding punctuation in chat message statuses

Fixed in ca288c9; shipped in v2.10

@MMK21Hub
Copy link
Owner Author

MMK21Hub commented Jul 21, 2022 •
edited
Loading

https://bugs.mojang.com/browse/MC-254428 seems correct anyway to me, so I'll wait for a triage by Mojang before adding it. I was correct: it's just been marked as WAI.

@MMK21Hub
Copy link
Owner Author

Fixing https://bugs.mojang.com/browse/MC-158539 will be fun

@MMK21Hub
Copy link
Owner Author

MMK21Hub commented Aug 8, 2022 •
edited
Loading

@MMK21Hub MMK21Hub pinned this issue Aug 14, 2022
@MMK21Hub
Copy link
Owner Author

https://bugs.mojang.com/browse/MC-256422 Some words within some strings use right single quotation marks instead of apostrophes

What a poetic bug report description

Furthermore, they both render differently in Minecraft's font which may convey the idea that they serve different purposes from one another, thus potentially creating additional perplexity.

@MMK21Hub
Copy link
Owner Author

MMK21Hub commented Nov 16, 2022 •
edited
Loading

MC-257618 The "telemetry.event.world_loaded.description" string incorrectly spells the word "paired" as "pair"
Done

@MMK21Hub
Copy link
Owner Author

MMK21Hub commented Dec 9, 2022 •
edited
Loading

https://bugs.mojang.com/browse/MC-258246 "Telemetry Data" button has no ellipsis
Fixed in ca1540a

@MMK21Hub
Copy link
Owner Author

MMK21Hub commented Dec 10, 2022 •
edited
Loading

MC-219541 has been expanded and the pack no longer fully fixes it. (Avoma's comment)
Fix updated in 03e08fb

@MMK21Hub
Copy link
Owner Author

MMK21Hub commented Dec 11, 2022 •
edited
Loading

MC-258461 has been created to go along with MC-195781, so MC-258461 will need to be fixed too. Fixed in 2c44f00

@MMK21Hub
Copy link
Owner Author

MMK21Hub commented Jan 24, 2023 •
edited
Loading

We'll need to fix MC-259360 - The selectWorld.mapFeatures.info string is missing a comma before the word "etc" Fixed in commit 54d904e

@MMK21Hub
Copy link
Owner Author

MMK21Hub commented Aug 21, 2023 •
edited
Loading

Avoma's done what he does best and spotted another inconsistency: MC-264962 (References to keybinds with two keys are inconsistently formatted) Fixed in 95e958a

@MMK21Hub
Copy link
Owner Author

MC-256422 has been updated to mention a new string: abuseReport.report_sent_msg

@MMK21Hub
Copy link
Owner Author

I managed to miss MC-188265 - The word "blocks" within some "/locate" command feedback messages is always pluralized

@MMK21Hub
Copy link
Owner Author

https://bugs.mojang.com/browse/MC-189953 should be fixable

https://discord.com/channels/647810384031645728/648555495564509184/1153409347221733528

@MMK21Hub
Copy link
Owner Author

https://bugs.mojang.com/browse/MC-265583 "Incorrect pluralization for skin customization strings for pants" could be a bug, but I'll waste for this one to be triaged by Mojang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MMK21Hub